From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] fwts: new package
Date: Fri, 7 Oct 2016 15:59:41 +0200 [thread overview]
Message-ID: <20161007155941.180d0d29@free-electrons.com> (raw)
In-Reply-To: <1475592743-4058-1-git-send-email-nunes.erico@gmail.com>
Hello,
On Tue, 4 Oct 2016 16:52:22 +0200, Erico Nunes wrote:
> +++ b/package/fwts/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_FWTS
> + bool "fwts"
> + depends on BR2_i386 || BR2_x86_64 || BR2_aarch64
> + depends on BR2_USE_WCHAR # libglib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> + depends on BR2_USE_MMU # libglib2
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
You forgot to propagate this dependency...
> + depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_JSON_C
> + help
> + Firmware Test Suite (FWTS) is a test suite that performs
> + sanity checks on firmware. It is intended to identify BIOS and
> + ACPI errors and if appropriate it will try to explain the
> + errors and give advice to help workaround or fix firmware
> + bugs.
> +
> + dtc (libfdt) is an optional dependency for fdt related tests.
> +
> + https://wiki.ubuntu.com/FirmwareTestSuite
> +
> +comment "fwts needs a glibc toolchain w/ wchar, threads"
> + depends on BR2_i386 || BR2_x86_64 || BR2_aarch64
> + depends on BR2_USE_MMU
... here.
So I've added that.
> + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> + !BR2_TOOLCHAIN_USES_GLIBC
> +FWTS_VERSION = V16.09.00
> +FWTS_SITE = http://fwts.ubuntu.com/release
> +FWTS_STRIP_COMPONENTS = 0
> +FWTS_LICENSE = GPLv2, LGPL, Custom
The LGPL version is 2.1, so I've changed LGPL to LGPLv2.1.
Committed with those issues fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-10-07 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 14:52 [Buildroot] [PATCH 1/2] fwts: new package Erico Nunes
2016-10-04 14:52 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add entry for fwts Erico Nunes
2016-10-07 13:59 ` Thomas Petazzoni
2016-10-07 13:59 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007155941.180d0d29@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox