From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 13/13] Remove BR2_DEPRECATED
Date: Sat, 15 Oct 2016 16:51:07 +0200 [thread overview]
Message-ID: <20161015145107.18264-14-arnout@mind.be> (raw)
In-Reply-To: <20161015145107.18264-1-arnout@mind.be>
The BR2_DEPRECATED logic is a lot less useful than the legacy handling,
because the symbols just disappears without warning to the user. For
example, we had a few defconfigs that were using deprecated symbols
(which were not actually used because BR2_DEPRECATED wasn't set) so
these didn't build the expected code anymore.
Also, the idea behind BR2_DEPRECATED is that you can easily revive it
again if there is interest. However, it is relatively easy to revert
the removal of a package as well.
The deprecation is also more effort because it has to be removed twice:
once when deprecating, and once when really removing.
It doesn't make sense to add a legacy entry for BR2_DEPRECATED. Users
who actually used it will get legacy warnings instead.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Config.in | 30 ------------------------------
Makefile | 2 --
Makefile.legacy | 3 ---
3 files changed, 35 deletions(-)
diff --git a/Config.in b/Config.in
index 8d37c93..d9fc400 100644
--- a/Config.in
+++ b/Config.in
@@ -361,36 +361,6 @@ config BR2_CCACHE_USE_BASEDIR
endif
-config BR2_DEPRECATED
- bool "Show options and packages that are deprecated or obsolete"
- help
- This option shows outdated/obsolete versions of packages and
- options that are otherwise hidden.
-
-if BR2_DEPRECATED
-
-config BR2_DEPRECATED_SINCE_2015_11
- bool
- default y
-
-config BR2_DEPRECATED_SINCE_2016_02
- bool
- default y
-
-config BR2_DEPRECATED_SINCE_2016_05
- bool
- default y
-
-config BR2_DEPRECATED_SINCE_2016_08
- bool
- default y
-
-config BR2_DEPRECATED_SINCE_2016_11
- bool
- default y
-
-endif
-
config BR2_ENABLE_DEBUG
bool "build packages with debugging symbols"
help
diff --git a/Makefile b/Makefile
index 74b831e..4110861 100644
--- a/Makefile
+++ b/Makefile
@@ -436,9 +436,7 @@ all: world
# Include legacy before the other things, because package .mk files
# may rely on it.
-ifneq ($(BR2_DEPRECATED),y)
include Makefile.legacy
-endif
include package/Makefile.in
include support/dependencies/dependencies.mk
diff --git a/Makefile.legacy b/Makefile.legacy
index 764cfcd..800c089 100644
--- a/Makefile.legacy
+++ b/Makefile.legacy
@@ -4,9 +4,6 @@
# This file contains placeholders to detect backward-compatibility problems.
# When a buildroot "API" feature is being deprecated, a rule should be added
# here that issues an error when the old feature is used.
-#
-# This file is not included if BR2_DEPRECATED is selected, so it is possible
-# to bypass the errors (although that's usually a bad idea).
ifeq ($(BR2_LEGACY),y)
$(error "You have legacy configuration in your .config! Please check your configuration.")
--
2.9.3
next prev parent reply other threads:[~2016-10-15 14:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 14:50 [Buildroot] Deprecate BR2_DEPRECATED Arnout Vandecappelle
2016-10-15 14:50 ` [Buildroot] [PATCH 01/13] configs/freescale_p1010rdb_pa: remove U-Boot build Arnout Vandecappelle
2016-10-15 18:01 ` Peter Korsgaard
2016-10-15 14:50 ` [Buildroot] [PATCH 02/13] configs/freescale_mpc8315erdb: " Arnout Vandecappelle
2016-10-15 18:02 ` Peter Korsgaard
2016-10-15 14:50 ` [Buildroot] [PATCH 03/13] binutils: remove deprecated 2.24.X Arnout Vandecappelle
2016-10-15 18:04 ` Peter Korsgaard
2016-10-15 14:50 ` [Buildroot] [PATCH 04/13] gcc: remove deprecated 4.7.x Arnout Vandecappelle
2016-10-15 15:18 ` Thomas Petazzoni
2016-10-15 16:28 ` Arnout Vandecappelle
2016-10-15 19:26 ` Peter Korsgaard
2016-10-15 14:50 ` [Buildroot] [PATCH 05/13] ipkg: remove deprecated package Arnout Vandecappelle
2016-10-15 20:57 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 06/13] kodi-addon-xvdr: " Arnout Vandecappelle
2016-10-15 21:00 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 07/13] linux-headers: remove deprecated version 4.2 and 4.3 Arnout Vandecappelle
2016-10-15 21:00 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 08/13] sstrip: remove deprecated package Arnout Vandecappelle
2016-10-15 21:02 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 09/13] torsmo: " Arnout Vandecappelle
2016-10-15 21:03 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 10/13] webkitgtk24: " Arnout Vandecappelle
2016-10-15 21:04 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 11/13] wvdial: " Arnout Vandecappelle
2016-10-15 21:05 ` Peter Korsgaard
2016-10-15 14:51 ` [Buildroot] [PATCH 12/13] wvstreams: " Arnout Vandecappelle
2016-10-15 21:05 ` Peter Korsgaard
2016-10-15 14:51 ` Arnout Vandecappelle [this message]
2016-10-15 21:07 ` [Buildroot] [PATCH 13/13] Remove BR2_DEPRECATED Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015145107.18264-14-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox