Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] inadyn: do not install default conf file
Date: Sun, 16 Oct 2016 18:11:22 +0200	[thread overview]
Message-ID: <20161016181122.01729058@free-electrons.com> (raw)
In-Reply-To: <20161013034247.21603-2-bluemrp9@gmail.com>

Hello,

On Wed, 12 Oct 2016 20:42:46 -0700, Ryan Coe wrote:
> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>

The commit message is empty, and therefore we don't understand why you
are removing this default configuration file. Having a default
configuration file seems very useful: it clearly shows to the user what
needs to be tweaked to configure inadyn.

What is your motivation for removing this? Is it because the 2.0
version has a different configuration file format? Something else?

Please write a more verbose commit log, in any case.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-10-16 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13  3:42 [Buildroot] [PATCH 1/3] libite: new package Ryan Coe
2016-10-13  3:42 ` [Buildroot] [PATCH 2/3] inadyn: do not install default conf file Ryan Coe
2016-10-16 16:11   ` Thomas Petazzoni [this message]
2016-10-13  3:42 ` [Buildroot] [PATCH 3/3] inadyn: bump to version 2.0 Ryan Coe
2016-10-16 16:14   ` Thomas Petazzoni
2016-10-16 16:06 ` [Buildroot] [PATCH 1/3] libite: new package Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161016181122.01729058@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox