From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] motion: fix sdl-config detection
Date: Tue, 18 Oct 2016 12:02:52 +0200 [thread overview]
Message-ID: <20161018120252.2e27edf2@free-electrons.com> (raw)
In-Reply-To: <1476737088-1492-1-git-send-email-ps.report@gmx.net>
Hello,
On Mon, 17 Oct 2016 22:44:48 +0200, Peter Seiderer wrote:
> Overwrite ac_cv_path_CONFIG_SDL in case sdl development is
> installed on the host.
>
> Fixes [1]:
>
> ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/SDL'
>
> [1] http://autobuild.buildroot.net/results/459/4592eb83efa393f77f5ee014f93a271f2313bee6
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
I've applied to master, however, one question below.
> ifeq ($(BR2_PACKAGE_SDL),y)
> MOTION_DEPENDENCIES += sdl
> MOTION_CONF_OPTS += --with-sdl=$(STAGING_DIR)/usr
With the ac_cv_path_CONFIG_SDL, is this --with-sdl still really
necessary?
If it uses the sdl-config script to get the SDL path, then it should
theoretically no longer be needed.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-18 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:44 [Buildroot] [PATCH v1] motion: fix sdl-config detection Peter Seiderer
2016-10-18 10:02 ` Thomas Petazzoni [this message]
2016-10-18 19:01 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018120252.2e27edf2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox