From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: fix misspelling of "directfb"
Date: Tue, 18 Oct 2016 15:51:19 +0200 [thread overview]
Message-ID: <20161018155119.06d87f56@free-electrons.com> (raw)
In-Reply-To: <20161018134754.lp7vtfqt3j33hp5z@ftbfs.org>
Hello,
On Tue, 18 Oct 2016 06:47:54 -0700, Matt Kraai wrote:
> If the comment is removed, then there is no indication that a directfb
> backend is available if directfb is disabled. That's inconsistent
> with the handling of the other backends, which have the following
> comments if they're not available:
>
> * X.org XCB backend available if X.org is enabled
> * eglfs backend available if OpenGL and EGL are enabled
Indeed.
> Should I still remove the comment? Or make the message consistent
> with the other backends (i.e., "directfb backend available if directfb
> is enabled")?
Let's keep the comment, just adjusted.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-10-18 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 2:09 [Buildroot] [PATCH] qt5base: fix misspelling of "directfb" Matt Kraai
2016-10-18 9:45 ` Thomas Petazzoni
2016-10-18 13:47 ` Matt Kraai
2016-10-18 13:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018155119.06d87f56@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox