From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Thu, 20 Oct 2016 20:55:55 +0300 Subject: [Buildroot] [PATCH RFC] package/wireshark: fix kconfig depndencies In-Reply-To: <1476980905-3997-1-git-send-email-yann.morin.1998@free.fr> References: <1476980905-3997-1-git-send-email-yann.morin.1998@free.fr> Message-ID: <20161020175554.okl6cbxvpzos3m2k@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Yann, On Thu, Oct 20, 2016 at 06:28:25PM +0200, Yann E. MORIN wrote: > Commit fa6feff (wireshark: needs the qt5tools lrelease utility) > introduced a circular dependency chain in Kconfig: > > package/qt5/qt5base/Config.in:118:error: recursive dependency detected! > package/qt5/qt5base/Config.in:118: symbol BR2_PACKAGE_QT5BASE_GUI is selected by BR2_PACKAGE_QT5TOOLS_PIXELTOOL > package/qt5/qt5tools/Config.in:19: symbol BR2_PACKAGE_QT5TOOLS_PIXELTOOL depends on BR2_PACKAGE_QT5TOOLS > package/qt5/qt5tools/Config.in:1: symbol BR2_PACKAGE_QT5TOOLS is selected by BR2_PACKAGE_QT5BASE_WIDGETS > package/qt5/qt5base/Config.in:131: symbol BR2_PACKAGE_QT5BASE_WIDGETS is selected by BR2_PACKAGE_QT5X11EXTRAS > package/qt5/qt5x11extras/Config.in:1: symbol BR2_PACKAGE_QT5X11EXTRAS depends on BR2_PACKAGE_QT5BASE_XCB > package/qt5/qt5base/Config.in:186: symbol BR2_PACKAGE_QT5BASE_XCB depends on BR2_PACKAGE_QT5BASE_GUI > > Fix that by dropping the select on the Qt5Tools, and introduce an > intermediate kconfig-level variable to represent the new condition, to > simplify the .mk file. > > That would make the condition for enabling/disabling the GUI to be a > little bit more complex by adding yet another (long-ish) variable. > > So we also introduce an intermediate kconfig-level variable that > represent the condition to enable the GUI. > > Reported-by: Thomas Petazzoni > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > Cc: Baruch Siach > > --- > Note: UNTESTED. It does fix the Kconfig issue, but it is otherwise not > even build-tested. Baruch? ;-) Thanks for your analysis and patch. I build tested one of the defconfigs that commit fa6feffa0def mentions. Then selected BR2_PACKAGE_QT5TOOLS manually, and built wireshark again. In both cases build succeeds after applying another (unrelated) patch[1]. So: Tested-by: Baruch Siach [1] http://patchwork.ozlabs.org/patch/684715/ baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -