From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] protobuf: bump to version 3.0.0
Date: Sat, 22 Oct 2016 16:07:53 +0200 [thread overview]
Message-ID: <20161022160753.65f5e3d5@free-electrons.com> (raw)
In-Reply-To: <1476983609-17269-1-git-send-email-heyleke@gmail.com>
Hello,
On Thu, 20 Oct 2016 19:13:29 +0200, Jan Heylen wrote:
> Signed-off-by: Jan Heylen <heyleke@gmail.com>
> ---
> ...GLE_PROTOBUF_ATOMICOPS_ERROR-syntax-error.patch | 61 ----------------------
> ...onfigure.ac-check-if-libatomic-is-needed.patch} | 4 +-
> package/protobuf/protobuf.hash | 2 +-
> package/protobuf/protobuf.mk | 2 +-
> 4 files changed, 4 insertions(+), 65 deletions(-)
> delete mode 100644 package/protobuf/0001-Fix-GOOGLE_PROTOBUF_ATOMICOPS_ERROR-syntax-error.patch
> rename package/protobuf/{0002-configure.ac-check-if-libatomic-is-needed.patch => 0001-configure.ac-check-if-libatomic-is-needed.patch} (85%)
I've applied, but you forgot to test building the python-protobuf
package, which uses the same source code. So I've fixed that up, and
also added a comment in protobuf.mk to remind people bumping this
package to also check python-protobuf.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-22 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 17:13 [Buildroot] [PATCH 1/1] protobuf: bump to version 3.0.0 Jan Heylen
2016-10-22 14:07 ` Thomas Petazzoni [this message]
2016-10-22 19:08 ` Jan Heylen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161022160753.65f5e3d5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox