From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] openzwave: fix compilation of MinOZW
Date: Sun, 23 Oct 2016 14:38:46 +0200 [thread overview]
Message-ID: <20161023143846.34c77ab4@free-electrons.com> (raw)
In-Reply-To: <1474988445-22639-1-git-send-email-fabrice.fontaine@orange.com>
Hello,
On Tue, 27 Sep 2016 17:00:45 +0200, Fabrice Fontaine wrote:
> LIBDIR was used in cpp/examples/MinOZW/Makefile to add dynamic
> libraries. However, as it was unset by default, the cross-compilation
> could fail if the host had a library such as libnss3.so in /.
> To fix this issue, this patch sets LIBDIR to top_buildir if it is unset
>
> Fixes:
> http://autobuild.buildroot.net/results/68719fdf1320a69310bada6d3c47654dacdb5898
>
> Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Why is a patch needed?
Doing the following seems to be sufficient:
diff --git a/package/openzwave/openzwave.mk b/package/openzwave/openzwave.mk
index 2723086..9c50cb8 100644
--- a/package/openzwave/openzwave.mk
+++ b/package/openzwave/openzwave.mk
@@ -29,7 +29,8 @@ OPENZWAVE_MAKE_OPTS = \
instlibdir=/usr/lib \
pkgconfigdir=/usr/lib/pkgconfig \
sysconfdir=/etc/openzwave \
- DOXYGEN=
+ DOXYGEN= \
+ LIBDIR=$(@D)
define OPENZWAVE_BUILD_CMDS
$(TARGET_MAKE_ENV) $(MAKE) $(OPENZWAVE_MAKE_OPTS) -C $(@D)
If you agree with this, could you submit a patch with this solution,
preferably after adding a comment that explains why we're passing such
a strange value for LIBDIR.
Of course, please submit a bug report to the upstream project.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-10-23 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 15:00 [Buildroot] [PATCH 1/1] openzwave: fix compilation of MinOZW Fabrice Fontaine
2016-10-23 12:38 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023143846.34c77ab4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox