Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] firejail: new package
Date: Mon, 24 Oct 2016 23:40:44 +0200	[thread overview]
Message-ID: <20161024234044.2749e6a6@free-electrons.com> (raw)
In-Reply-To: <1476986053-11910-1-git-send-email-cdf123@cdf123.net>

Hello,

Thanks for this contribution!

On Thu, 20 Oct 2016 12:54:13 -0500, Chris Frederick wrote:
> Firejail Security Sandbox
> https://firejail.wordpress.com/
> 
> Lightweight application sandboxing system using seccomp and kernel
> namespaces.
> 
> Signed-off-by: Chris Frederick <cdf123@cdf123.net>

This package does not cross-compile properly: building for an ARM
target, it produces a host binary (x86-64) in my case:

$ file output/target/usr/bin/firejail 
output/target/usr/bin/firejail: setuid ELF 64-bit LSB shared object, x86-64 [...]

In addition, it's using fork(), so you need a BR2_USE_MMU dependency,
it uses pthread so you need a BR2_TOOLCHAIN_HAS_THREADS dependency.

Also, the license is GPLv2+ apparently, not GPLv2.

Finally, please include in the same patch series a patch updating the
DEVELOPERS file for this new package addition.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-10-24 21:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 17:54 [Buildroot] [PATCH 1/1] firejail: new package Chris Frederick
2016-10-24 21:40 ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-26 17:22 Chris Frederick
2017-01-28 14:35 ` Romain Naour
2017-03-07 20:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024234044.2749e6a6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox