From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kvm-unit-tests: Fix x86_64 to use host compiler
Date: Tue, 25 Oct 2016 12:15:28 +0200 [thread overview]
Message-ID: <20161025121528.7880d604@free-electrons.com> (raw)
In-Reply-To: <20161025054240.10957-1-cyrilbur@gmail.com>
Cyril,
Thanks for fixing this issue!
On Tue, 25 Oct 2016 16:42:40 +1100, Cyril Bur wrote:
> diff --git a/package/kvm-unit-tests/kvm-unit-tests.mk b/package/kvm-unit-tests/kvm-unit-tests.mk
> index 7fd03ad..cdce1e4 100644
> --- a/package/kvm-unit-tests/kvm-unit-tests.mk
> +++ b/package/kvm-unit-tests/kvm-unit-tests.mk
> @@ -4,20 +4,25 @@
> #
> ################################################################################
>
> -KVM_UNIT_TESTS_VERSION = 0b04ed0610035792514fd8499eb4dacc185520d9
> +KVM_UNIT_TESTS_VERSION = 9111ccab0bb42d93d9f2b84c9089b5790e763056
Is this bump related to using the host compiler on x86-64 ? I don't
think it is, so it should be a separate patch. Or if it's related, it
should be explained in the commit log.
> KVM_UNIT_TESTS_SITE = $(BR2_KERNEL_MIRROR)/scm/virt/kvm/kvm-unit-tests.git
> KVM_UNIT_TESTS_SITE_METHOD = git
> KVM_UNIT_TESTS_LICENSE = LGPLv2
> KVM_UNIT_TESTS_LICENSE_FILES = COPYRIGHT
>
> +#Use HOSTCC for x86_64 as we'll need to compile 32bit code
> +#which buildroot cross compilers often can't do
Add one space after the # on each line.
> +ifeq ($(BR2_x86_64),y)
> +KVM_UNIT_TESTS_ARCH = x86_84
> +else
> +KVM_UNIT_TESTS_CONF_OPTS = --cross-prefix="$(TARGET_CROSS)"
> +endif
> ifeq ($(BR2_arm),y)
> KVM_UNIT_TESTS_ARCH = arm
> else ifeq ($(BR2_i386),y)
> KVM_UNIT_TESTS_ARCH = i386
> else ifeq ($(BR2_powerpc64)$(BR2_powerpc64le),y)
> KVM_UNIT_TESTS_ARCH = ppc64
> -else ifeq ($(BR2_x86_64),y)
> -KVM_UNIT_TESTS_ARCH = x86_84
> endif
Please keep this sequence of ifeq / else ifeq / else ifeq / endif, and
instead add:
# For all architectures but x86-64, use the cross-compiler. On x86-64,
# use the host compiler, since we need to build 32 bits binaries
ifneq ($(BR2_x86_64),y)
KVM_UNIT_TESTS_CONF_OPTS = --cross-prefix="$(TARGET_CROSS)"
endif
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-25 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 5:42 [Buildroot] [PATCH] kvm-unit-tests: Fix x86_64 to use host compiler Cyril Bur
2016-10-25 10:15 ` Thomas Petazzoni [this message]
2016-10-26 3:20 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025121528.7880d604@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox