From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libglob: new package
Date: Tue, 25 Oct 2016 21:55:08 +0200 [thread overview]
Message-ID: <20161025215508.7fe47ff8@free-electrons.com> (raw)
In-Reply-To: <20160801195836.30837-1-joerg.krause@embedded.rocks>
Hello,
On Mon, 1 Aug 2016 21:58:36 +0200, J?rg Krause wrote:
> libglob is the OpenBSD implementation of glob(3).
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
I've applied your patch, with one minor change (see below).
I remember this was necessary to fix the build of a package with musl.
Do you remember which one?
> +ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
I've added:
LIBGLOB_MAKE_TARGETS += libglob.so
here.
> +# $1: destination directory
> +define LIBGLOB_INSTALL_SHARED
> + $(INSTALL) -m 0755 -D $(@D)/libglob.so.0.0.0 \
> + $(1)/usr/lib/libglob.so.0.0.0
> + ln -sf libglob.so.0.0.0 $(1)/usr/lib/libglob.so.0
> + ln -sf libglob.so.0.0.0 $(1)/usr/lib/libglob.so
> +endef
> +endif
> +
> +ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
LIBGLOB_MAKE_TARGETS += libglob.a
here.
> +# $1: destination directory
> +define LIBGLOB_INSTALL_STATIC
> + $(INSTALL) -m 0644 -D $(@D)/libglob.a $(1)/usr/lib/libglob.a
> +endef
> +endif
> +
> +define LIBGLOB_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> + $(if $(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),libglob.so) \
> + $(if $(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),libglob.a)
And replaced those two lines by:
$(LIBGLOB_MAKE_TARGETS)
This way, we have the conditions around static/shared only in one place.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-25 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 19:58 [Buildroot] [PATCH] libglob: new package Jörg Krause
2016-08-01 20:07 ` Thomas Petazzoni
2016-10-25 19:55 ` Thomas Petazzoni [this message]
2016-11-02 19:10 ` Jörg Krause
2016-11-02 20:32 ` Thomas Petazzoni
2016-11-02 22:43 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025215508.7fe47ff8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox