From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RESEND][PATCH v2 2/3] gcc: configs: rename BR2_EXTRA_GCC_CONFIG_OPTIONS
Date: Tue, 25 Oct 2016 23:35:22 +0200 [thread overview]
Message-ID: <20161025233522.4452eba8@free-electrons.com> (raw)
In-Reply-To: <1470681301-6374-2-git-send-email-pgynther@google.com>
Hello,
On Mon, 8 Aug 2016 11:35:00 -0700, Petri Gynther wrote:
> Rename BR2_EXTRA_GCC_CONFIG_OPTIONS to BR2_GCC_EXTRA_CONFIG_OPTIONS
> to be consistent with BR2_GCC_* and BR2_BINUTILS_EXTRA_CONFIG_OPTIONS.
>
> Signed-off-by: Petri Gynther <pgynther@google.com>
I've rejected this patch (2/3) and the following one (3/3). Indeed,
those renames are not really necessary, and renaming options causes
unnecessary breakage of existing configurations. So the benefit of the
rename is too small compared to the breakage for users. I know it's
annoying, I would also prefer to have a more consistent option naming,
but some amount of backward compatibility is more important.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-25 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 18:34 [Buildroot] [RESEND][PATCH v2 1/3] toolchain: configs: improve toolchain config readability Petri Gynther
2016-08-08 18:35 ` [Buildroot] [RESEND][PATCH v2 2/3] gcc: configs: rename BR2_EXTRA_GCC_CONFIG_OPTIONS Petri Gynther
2016-10-25 21:35 ` Thomas Petazzoni [this message]
2016-08-08 18:35 ` [Buildroot] [RESEND][PATCH v2 3/3] uclibc: configs: rename BR2_PTHREAD_DEBUG Petri Gynther
2016-08-16 17:51 ` [Buildroot] [RESEND][PATCH v2 1/3] toolchain: configs: improve toolchain config readability Petri Gynther
2016-10-25 21:34 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025233522.4452eba8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox