From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts: tool to create fragments
Date: Wed, 26 Oct 2016 16:17:52 +0200 [thread overview]
Message-ID: <20161026161752.0fa1a3da@free-electrons.com> (raw)
In-Reply-To: <CAH=K+6khOEyfhomv9HMbOnB7eNcgiX4V0Z_vALNLDAdL5QLVww@mail.gmail.com>
Hello,
On Wed, 26 Oct 2016 09:06:12 -0500, Sam Voss wrote:
> Assuming you have already done a `make linux-savedefconfig` and have
> an older version to compare against (example files given below), it
> would be used (from the
> buildroot root directory) as follows:
>
> ./support/scripts/gen-config-fragment.sh
> output/build/linux-4.8.1/defconfig board/qemu/x86_64/linux-4.8.config
[...]
> Giving output file of - output/build/linux-4.8.1/defconfig.fragment
>
> CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_DEVTMPFS=y
> # CONFIG_X86_MPPARSE is not set
OK, understood. So in fact, you have reimplemented the diffconfig tool
available in the Linux kernel scripts/ directory. For your two
configuration files, it shows:
thomas at skate:/tmp$ ~/projets/linux-2.6/scripts/diffconfig config1 config2
-DEVTMPFS y
-DEVTMPFS_MOUNT y
-X86_MPPARSE n
Though I agree that your output format is better, as it can be re-used
as a fragment as-is.
However, calling it gen-config-fragment looks a bit wrong to me. What
about diffconfig, like in the Linux kernel?
> Should I add an example execution of this in the header of the script?
> Something like the following?
>
> #
> # Linux Example
> # ./support/scripts/gen-config-fragment.sh <output
> dir>/build/linux-x.y.z/defconfig
> board/custom-board/linux-x.y.z.config
> #
> # Busybox Example using default base config
> # ./support/scripts/gen-config-fragment.sh <output
> dir>/build/busybox-x.y.z/.config
> #
> # Busybox Example using custom base config
> # ./support/scripts/gen-config-fragment.sh <output
> dir>/build/busybox-x.y.z/.config board/custom-board/busybox.config
No need to give so many examples, but just one example would be good.
In terms of implementation, should we re-use the diffconfig tool from
the kernel, simply tweaked in terms of output format?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-26 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 20:01 [Buildroot] [PATCH] support/scripts: tool to create fragments Matt Weber
2016-10-25 20:03 ` Thomas Petazzoni
2016-10-26 14:06 ` Sam Voss
2016-10-26 14:17 ` Thomas Petazzoni [this message]
2016-10-26 15:45 ` Sam Voss
2016-10-25 21:21 ` Matthew Weber
2016-10-26 21:17 ` Yann E. MORIN
2016-10-26 21:19 ` Yann E. MORIN
2016-10-26 21:28 ` Thomas Petazzoni
2016-10-26 21:38 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026161752.0fa1a3da@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox