From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/11] perl: use $(TARGET_MAKE_ENV) when calling $(MAKE)
Date: Sat, 29 Oct 2016 15:57:09 +0200 [thread overview]
Message-ID: <20161029155709.62a38067@free-electrons.com> (raw)
In-Reply-To: <1477660709-5935-6-git-send-email-gustavo.zacarias@free-electrons.com>
Hello,
On Fri, 28 Oct 2016 10:18:24 -0300, gustavo.zacarias at free-electrons.com
wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
>
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
> package/perl/perl.mk | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/package/perl/perl.mk b/package/perl/perl.mk
> index a8768b2..b19fa78 100644
> --- a/package/perl/perl.mk
> +++ b/package/perl/perl.mk
> @@ -81,20 +81,21 @@ PERL_CONF_OPTS += --only-mod=$(subst $(space),$(comma),$(PERL_MODULES))
> endif
>
> define PERL_CONFIGURE_CMDS
> - (cd $(@D); HOSTCC='$(HOSTCC_NOCCACHE)' ./configure $(PERL_CONF_OPTS))
> + (cd $(@D); HOSTCC='$(HOSTCC_NOCCACHE)' $(TARGET_MAKE_ENV) \
I think it makes more sense to have $(TARGET_MAKE_ENV) before HOSTCC=,
since HOSTCC= is package-specific, and should therefore appear after
the more "global" TARGET_MAKE_ENV variable.
I did the same change in patch 07/11 for the host variant of perl.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-29 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 13:18 [Buildroot] [PATCH 01/11] cryptopp: use $(HOST_MAKE_ENV) when calling $(MAKE) gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 02/11] lzip: " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 03/11] lzip: use $(TARGET_MAKE_ENV) for configure as well gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 04/11] libselinux: use $(TARGET_MAKE_ENV) when calling $(MAKE) gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 05/11] libselinux: use $(HOST_MAKE_ENV) " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 06/11] perl: use $(TARGET_MAKE_ENV) " gustavo.zacarias at free-electrons.com
2016-10-29 13:57 ` Thomas Petazzoni [this message]
2016-10-28 13:18 ` [Buildroot] [PATCH 07/11] perl: use $(HOST_MAKE_ENV) " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 08/11] dtc: use $(TARGET_CONFIGURE_OPTS) " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 09/11] ezxml: use $(TARGET_MAKE_ENV) " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 10/11] fmlib: " gustavo.zacarias at free-electrons.com
2016-10-28 13:18 ` [Buildroot] [PATCH 11/11] qt: " gustavo.zacarias at free-electrons.com
2016-10-29 13:57 ` Thomas Petazzoni
2016-10-29 13:56 ` [Buildroot] [PATCH 01/11] cryptopp: use $(HOST_MAKE_ENV) " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029155709.62a38067@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox