From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Bump libxmlrpc
Date: Wed, 2 Nov 2016 23:26:46 +0100 [thread overview]
Message-ID: <20161102232646.69bfff3d@free-electrons.com> (raw)
In-Reply-To: <1478080601-8754-1-git-send-email-alvaro.gamez@hazent.com>
Hello,
On Wed, 2 Nov 2016 10:56:41 +0100, Alvaro G. M wrote:
> Signed-off-by: Alvaro Gamez <alvaro.gamez@hazent.com>
Thanks for your contribution. However, there are a few issues with it:
- The title should be:
libxmlrpc: bump to version xyz
- The commit log should contain a lot more details, especially:
* what changes are made to the patches
* why you are adding the AR and RANLIB definitions in MAKE_OPTS
Could you rework your patch accordingly?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-02 22:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160825063044.CF4CA101E4C@stock.ovh.net>
2016-11-02 9:56 ` [Buildroot] [PATCH 1/1] Bump libxmlrpc Alvaro G. M
2016-11-02 22:26 ` Thomas Petazzoni [this message]
2016-11-03 6:13 ` Alvaro Gamez
2016-11-11 7:58 ` [Buildroot] [PATCH v2] Bump libxmlrpc to version 1.39.10 Alvaro G. M
2016-11-11 14:38 ` Thomas Petazzoni
2016-11-15 10:49 ` Alvaro Gamez
2016-11-15 10:50 ` [Buildroot] [PATCH v3 1/1] libxmlrpc: bump to 1.39.11 Alvaro G. M
2016-11-16 22:15 ` Thomas Petazzoni
2016-11-17 8:00 ` Alvaro Gamez
2016-12-04 14:06 ` Thomas Petazzoni
2016-12-04 15:33 ` Alvaro G. M.
2016-12-04 15:37 ` Thomas Petazzoni
2016-12-04 15:55 ` [Buildroot] [PATCH 1/1] libxmlrpc: fix build without C++ compiler Alvaro G. M
2016-12-04 20:49 ` Thomas Petazzoni
2016-12-04 16:18 ` [Buildroot] [PATCH v3 1/1] libxmlrpc: bump to 1.39.11 Alvaro G. M.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102232646.69bfff3d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox