Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] musl with kernel headers (was: [PATCH] bridge-utils: fix build with musl)
Date: Fri, 4 Nov 2016 07:22:44 +0200	[thread overview]
Message-ID: <20161104052244.c2qswgkglbwcod3a@tarshish> (raw)
In-Reply-To: <20161103224656.1e6466a6@free-electrons.com>

Hi Thomas,

On Thu, Nov 03, 2016 at 10:46:56PM +0100, Thomas Petazzoni wrote:
> > In a discussion of this issue on the musl list last year Rich Felker
> > suggested[1] the following hack for fixing the widespread musl issue with
> > packages using kernel headers:
> > 
> >  --- usr/include/linux/libc-compat.h-orig	2016-11-03 07:25:09.853807823 +0200
> >  +++ usr/include/linux/libc-compat.h	2016-11-03 07:25:49.602834223 +0200
> >  @@ -49,7 +49,7 @@
> >   #define _LIBC_COMPAT_H
> > 
> >   /* We have included glibc headers... */
> >  -#if defined(__GLIBC__)
> >  +#if 1
> > 
> >   /* Coordinate with glibc net/if.h header. */
> >   #if defined(_NET_IF_H) && defined(__USE_MISC)
> > 
> > I verified that it fixes this build failure. What do you think of that as a
> > temporary measure until musl finds a better solution[2]?
> 
> Yes, we probably need to do something like that. I'm sick of all the
> patches we need to fix this structure redefinition mess, so if we have
> a global solution, it would be nice. I guess it needs to be applied in
> both the linux-headers package and the toolchain-external package.

I was thinking if a sed call in TOOLCHAIN_TARGET_FINALIZE_HOOKS to simplify 
the hack. Would that work?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2016-11-04  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03  5:53 [Buildroot] [PATCH] bridge-utils: fix build with musl Baruch Siach
2016-11-03 21:46 ` Thomas Petazzoni
2016-11-04  5:22   ` Baruch Siach [this message]
2016-11-04  8:16     ` [Buildroot] musl with kernel headers (was: [PATCH] bridge-utils: fix build with musl) Thomas Petazzoni
2016-11-05 22:49       ` Baruch Siach
2016-11-06  1:25         ` [Buildroot] musl with kernel headers Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104052244.c2qswgkglbwcod3a@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox