From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6] kodi: allow enablement of libamcodec as codec if selected
Date: Sat, 5 Nov 2016 17:12:03 +0100 [thread overview]
Message-ID: <20161105171203.216e4ffc@free-electrons.com> (raw)
In-Reply-To: <20161105154042.11063-1-daggs@gmx.com>
Hello,
On Sat, 5 Nov 2016 17:40:42 +0200, Dagg Stompler wrote:
> diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
> index e0361da..4682d3f 100644
> --- a/package/kodi/kodi.mk
> +++ b/package/kodi/kodi.mk
> @@ -113,6 +113,12 @@ KODI_DEPENDENCIES += imx-vpuwrap
> KODI_CONF_OPTS += --enable-codec=imxvpu
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBAMCODEC),y)
> +KODI_DEPENDENCIES += libamcodec
> +KODI_CONF_OPTS += --enable-codec=amcodec
> +KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/amcodec"
> +endif
This is not good for two reasons:
1. Because the Kodi Makefile for amcodec currently does
-I$(prefix)/include, which will be detected by our paranoid wrapper
as a bogus path because -I/usr/include is incorrect when
cross-compiling.
2. Because there are now two conditions that pass a INCLUDES= value in
KODI_CONF_ENV, overwriting each other. Even if in practice they are
mutually exclusive (you won't build amcodec support and RPi support
in the same build), it is still dangerous.
Both of those problems were fixed by my proposal in your reply to your
PATCHv5, but for some reason you decided to not follow this proposal.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-05 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 15:40 [Buildroot] [PATCH v6] kodi: allow enablement of libamcodec as codec if selected Dagg Stompler
2016-11-05 16:12 ` Thomas Petazzoni [this message]
2016-11-05 18:41 ` daggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161105171203.216e4ffc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox