From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH master] net-tools: fix field with incomplete type error
Date: Mon, 7 Nov 2016 22:26:01 +0100 [thread overview]
Message-ID: <20161107222601.3527fcff@free-electrons.com> (raw)
In-Reply-To: <20161107151814.48924-1-Vincent.Riera@imgtec.com>
Hello,
On Mon, 7 Nov 2016 15:18:14 +0000, Vicente Olivert Riera wrote:
> Update 0002 patch to match the one sent as a pull request. The previous
> one introduced a new problem that has been addressed in the new version.
>
> Some Linux headers included in certain toolchains may not have an
> updated linux/if_tunnel.h which includes linux/ip.h, so we need to
> include it unconditionally otherwise linux/if_tunnel.h will use the
> struct iphdr before being defined and the compilation will fail in this
> way:
>
> In file included from iptunnel.c:33:0:
> /usr/include/linux/if_tunnel.h:37:16: error: field 'iph' has incomplete
> type
> struct iphdr iph;
> ^
>
> Pull request URL:
> https://sourceforge.net/p/net-tools/code/merge-requests/4/
>
> Fixes:
> http://autobuild.buildroot.net/results/34f/34f9b10ef6a613057e8f6457d8a0a2fa142ad123/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> ...02-iptunnel.c-do-not-include-netinet-ip.h.patch | 30 +++++++++++++++++-----
> 1 file changed, 24 insertions(+), 6 deletions(-)
Applied to master, thanks. However, note that this package still fails
to build with musl, even with this patch applied.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-11-07 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 15:18 [Buildroot] [PATCH master] net-tools: fix field with incomplete type error Vicente Olivert Riera
2016-11-07 21:26 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107222601.3527fcff@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox