From: "Jérôme Pouiller" <jezz@sysmic.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python3: fix double format detection
Date: Wed, 9 Nov 2016 10:25:08 +0100 [thread overview]
Message-ID: <20161109092508.4503-2-jezz@sysmic.org> (raw)
In-Reply-To: <20161109092508.4503-1-jezz@sysmic.org>
Python is not able to detect if compiler double representation is
compliant with IEE754:
checking whether C doubles are little-endian IEEE 754 binary64... no
checking whether C doubles are big-endian IEEE 754 binary64... no
checking whether C doubles are ARM mixed-endian IEEE 754 binary64... no
Accordingly 'legacy' mode isused. It is possible to check this at runtime by
check if 'sys.float_repr_style' contains 'short' or 'legacy'. Calculus
correctness is not garanteed with 'legacy'.
Problem is better described here:
http://stackoverflow.com/questions/29920294/what-causes-pythons-float-repr-style-to-use-legacy
https://bugs.python.org/issue7117
However, all gcc architecture use a representation compliant with IEE754. So,
we can enable it unconditionnaly.
Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
package/python3/python3.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/python3/python3.mk b/package/python3/python3.mk
index b3f31c0..cdbe6f0 100644
--- a/package/python3/python3.mk
+++ b/package/python3/python3.mk
@@ -126,6 +126,13 @@ PYTHON3_CONF_ENV += \
ac_cv_working_tzset=yes \
ac_cv_prog_HAS_HG=/bin/false
+# GCC is always compliant with IEEE754
+ifeq ($(call qstrip,$(BR2_ENDIAN)),LITTLE)
+PYTHON3_CONF_ENV += ac_cv_little_endian_double=yes
+else
+PYTHON3_CONF_ENV += ac_cv_big_endian_double=yes
+endif
+
# uClibc is known to have a broken wcsftime() implementation, so tell
# Python 3 to fall back to strftime() instead.
ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
--
2.9.3
next prev parent reply other threads:[~2016-11-09 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 9:25 [Buildroot] [PATCH 1/2] python: fix double format detection Jérôme Pouiller
2016-11-09 9:25 ` Jérôme Pouiller [this message]
2016-11-09 9:33 ` Baruch Siach
2016-11-09 21:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109092508.4503-2-jezz@sysmic.org \
--to=jezz@sysmic.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox