Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: fix striping of ld.so and libpthread
Date: Wed, 9 Nov 2016 23:18:38 +0100	[thread overview]
Message-ID: <20161109231838.6c57a9f9@free-electrons.com> (raw)
In-Reply-To: <20161109105727.7068-1-jezz@sysmic.org>

Hello,

Thanks for contributing this patch, this was definitely buggy.

In the commit title: striping -> stripping.

On Wed,  9 Nov 2016 11:57:27 +0100, J?r?me Pouiller wrote:
> If 'lib' is a symlink, 'find lib' does not return correct result. So, until now,

return *the* correct result. Also, it would have been good to explain
that this typically occurs when the "merged /usr" option is enabled.

> libpthread*.so* and ld-*.so* was not stripped when 'lib' was a symlink.
> 
> We fix tit by using 'find lib/' instead of 'find lib'

We fix *this*.

> @@ -644,7 +644,7 @@ target-finalize: $(PACKAGES)
>  		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
>  		$(TARGET_DIR)/usr/lib/cmake $(TARGET_DIR)/usr/share/cmake
>  	find $(TARGET_DIR)/usr/{lib,share}/ -name '*.cmake' -print0 | xargs -0 rm -f
> -	find $(TARGET_DIR)/lib $(TARGET_DIR)/usr/lib $(TARGET_DIR)/usr/libexec \
> +	find $(TARGET_DIR)/lib/ $(TARGET_DIR)/usr/lib/ $(TARGET_DIR)/usr/libexec/ \

This change should have been explained in the commit log: it's just
done for consistency, but doesn't fix anything by itself.

I've applied to master with those various issues fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      reply	other threads:[~2016-11-09 22:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 10:57 [Buildroot] [PATCH] infra: fix striping of ld.so and libpthread Jérôme Pouiller
2016-11-09 22:18 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109231838.6c57a9f9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox