Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH for-master] package/sane-backends: fix musl build issue
Date: Sat, 12 Nov 2016 19:21:09 +0100	[thread overview]
Message-ID: <20161112192109.79c2ea5d@free-electrons.com> (raw)
In-Reply-To: <1478900262-18239-1-git-send-email-romain.naour@gmail.com>

Hello,

On Fri, 11 Nov 2016 22:37:42 +0100, Romain Naour wrote:
> We should include config.h from sanei_backend.h in order to use the
> correct if/else HAVE_FOO.
> 
> For some reason with Glibc or uClibc there is no problem but with musl
> we have the following weird issue:
> 
> In file included from epsonds.h:41:0,
>                  from epsonds-jpeg.c:18:
> ../include/sane/sanei_backend.h:99:33: error: expected ';', identifier or '(' before 'int'
> 
> ../include/sane/sanei_backend.h:99:33: warning: useless type name in empty declaration
> 
> That's because HAVE_SIGPROCMASK is not defined although it's correctly
> detected by the configure script.
> 
> $ grep config.log
> config.log:#define HAVE_SIGPROCMASK 1
> 
> So, include config.h to avoid to redefine sigset_t.
> 
> Fixes:
> http://autobuild.buildroot.net/results/9f1/9f1f1cb727b5c5407e69172280a3dee880e55cdf
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Frank Hunleth <fhunleth@troodon-software.com>
> ---
>  .../0003-sane_backend-add-missing-config.h.patch   | 49 ++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 package/sane-backends/0003-sane_backend-add-missing-config.h.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-11-12 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 21:37 [Buildroot] [PATCH for-master] package/sane-backends: fix musl build issue Romain Naour
2016-11-12 18:09 ` Frank Hunleth
2016-11-12 22:11   ` Romain Naour
2016-11-12 18:21 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161112192109.79c2ea5d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox