From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH 1/1] pkg-autotools: generic configure fix for powerpc64
Date: Thu, 17 Nov 2016 12:16:38 +0100 [thread overview]
Message-ID: <20161117121638.1f8a9aef@free-electrons.com> (raw)
In-Reply-To: <e9261df3-b71b-1591-8064-3d1c9d82972d@mind.be>
Hello,
On Thu, 17 Nov 2016 12:06:42 +0100, Arnout Vandecappelle wrote:
> > /^\s*ppc\*-\*linux\*|powerpc\*-\*linux\*)$/ {
>
> How sure are you that no configure script will contain this line somewhere else
> than in the shared library test? You *have* to match the context as well - in
> particular the LD="${LD-ld} -m elf64ppc" part. This is possible with awk, but
> the patch approach is a lot simpler IMHO, and anyway easier to read.
Fine with me. I was also unsure the awk idea was better.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-17 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 4:15 [Buildroot] [RFC PATCH 1/1] pkg-autotools: generic configure fix for powerpc64 Sam Bobroff
2016-11-17 6:43 ` Bernd Kuhls
2016-11-17 8:55 ` Thomas Petazzoni
2016-11-18 0:35 ` Sam Bobroff
2016-11-17 10:05 ` Thomas Petazzoni
2016-11-17 11:06 ` Arnout Vandecappelle
2016-11-17 11:16 ` Thomas Petazzoni [this message]
2016-11-18 0:48 ` Sam Bobroff
2016-11-18 3:56 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117121638.1f8a9aef@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox