From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 02/15] reproducible: fix DATE/TIME macros in toolchain-wrapper
Date: Fri, 18 Nov 2016 12:37:04 +0100 [thread overview]
Message-ID: <20161118123704.00772557@free-electrons.com> (raw)
In-Reply-To: <1479460224-6119-3-git-send-email-jezz@sysmic.org>
Hello,
On Fri, 18 Nov 2016 10:10:11 +0100, J?r?me Pouiller wrote:
> +ifeq ($(BR2_REPRODUCIBLE),y)
> +TOOLCHAIN_WRAPPER_ARGS += -DBR_REPRODUCIBLE_TIME="\"\\\"`date -d @$(SOURCE_DATE_EPOCH) "+%T"`\\\"\""
> +TOOLCHAIN_WRAPPER_ARGS += -DBR_REPRODUCIBLE_DATE="\"\\\"`date -d @$(SOURCE_DATE_EPOCH) "+%b %e %Y"`\\\"\""
> +endif
Do we need to encode the dates in the wrapper, or should we have the
wrapper read at runtime the SOURCE_DATE_EPOCH environment variable?
I believe the latter is simpler, and matches better what future gcc
versions will do.
The only drawback is that people using the toolchain (through the
wrapper) outside of Buildroot will not benefit from the "fixed" date,
unless they define SOURCE_DATE_EPOCH in their environment. But I
believe this is OK, because this is anyway the behavior that they would
get by using the newest gcc versions that have this feature.
It would make all the quoting mess a bit simpler :)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-18 11:37 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 9:10 [Buildroot] [PATCH v2 00/15] Reproducible builds Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 01/15] reproducibility: generate SOURCE_DATE_EPOCH Jérôme Pouiller
2016-11-18 11:33 ` Thomas Petazzoni
2016-11-18 13:48 ` Jérôme Pouiller
2016-11-19 8:51 ` Arnout Vandecappelle
2016-11-19 9:51 ` Thomas Petazzoni
2016-11-19 10:01 ` Arnout Vandecappelle
2016-11-19 8:40 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 02/15] reproducible: fix DATE/TIME macros in toolchain-wrapper Jérôme Pouiller
2016-11-18 11:37 ` Thomas Petazzoni [this message]
2016-11-18 13:46 ` Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 03/15] reproducible: add '-n' to gzip invocations Jérôme Pouiller
2016-11-18 11:38 ` Thomas Petazzoni
2016-11-19 9:02 ` Arnout Vandecappelle
2016-11-19 13:49 ` Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 04/15] fs/tar: make results reproducible Jérôme Pouiller
2016-11-18 11:40 ` Thomas Petazzoni
2016-11-18 13:02 ` Jérôme Pouiller
2016-11-18 13:29 ` Thomas Petazzoni
2016-11-18 13:44 ` Jérôme Pouiller
2016-11-18 21:28 ` Thomas Petazzoni
2016-11-19 8:33 ` Arnout Vandecappelle
2016-11-19 13:56 ` Jérôme Pouiller
2016-11-19 9:12 ` Arnout Vandecappelle
2016-11-19 13:59 ` Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 05/15] reproducibility/linux: override build timestamp Jérôme Pouiller
2016-11-18 11:40 ` Thomas Petazzoni
2016-11-19 13:53 ` Jérôme Pouiller
2016-11-19 16:10 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 06/15] reproducibility/linux: inhibit build-id Jérôme Pouiller
2016-11-19 9:31 ` Arnout Vandecappelle
2016-11-19 14:04 ` Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 07/15] reproducibility/busybox: disable build timestamps Jérôme Pouiller
2016-11-18 11:41 ` Thomas Petazzoni
2016-11-19 9:32 ` Arnout Vandecappelle
2016-11-19 9:33 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 08/15] reproducible: lock modification times in $TARGET_DIR Jérôme Pouiller
2016-11-18 11:43 ` Thomas Petazzoni
2016-11-19 9:39 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 09/15] fakedate: new package Jérôme Pouiller
2016-11-18 11:48 ` Thomas Petazzoni
2016-11-19 13:24 ` Jérôme Pouiller
2016-11-19 10:21 ` Arnout Vandecappelle
2016-11-19 13:06 ` Jérôme Pouiller
2016-11-19 13:26 ` Arnout Vandecappelle
2016-11-19 13:38 ` Jérôme Pouiller
2016-11-22 10:59 ` Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 10/15] reproducible: enable fakedate Jérôme Pouiller
2016-11-18 11:49 ` Thomas Petazzoni
2016-11-18 13:53 ` Jérôme Pouiller
2016-11-19 10:22 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 11/15] python2: generate reproducible .pyc Jérôme Pouiller
2016-11-19 10:41 ` Arnout Vandecappelle
2016-11-19 12:35 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 12/15] python3: " Jérôme Pouiller
2016-11-18 9:10 ` [Buildroot] [PATCH v2 13/15] python2: remove full path from .pyc Jérôme Pouiller
2016-11-19 12:38 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 14/15] python3: " Jérôme Pouiller
2016-11-19 12:39 ` Arnout Vandecappelle
2016-11-18 9:10 ` [Buildroot] [PATCH v2 15/15] reproducible: improve help text Jérôme Pouiller
2016-11-19 12:45 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118123704.00772557@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox