From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Possible documentation error and a patch
Date: Sun, 20 Nov 2016 15:55:02 +0100 [thread overview]
Message-ID: <20161120155502.28130680@free-electrons.com> (raw)
In-Reply-To: <193601d24331$ffd8ea30$ff8abe90$@chordia.co.uk>
Hello,
On Sun, 20 Nov 2016 13:28:36 -0000, jerry at chordia.co.uk wrote:
> Greetings.
>
> I think the example here
> http://nightly.buildroot.org/manual.html#outside-br-custom has a couple of
> typos?
>
> The example layout has $BR2_EXTERNAL_BAR_42_DIR instead of
> $BR2_EXTERNAL_BAR_42_PATH in a couple of places and the source lines in the
> example config.in are incorrectly quoted.
>
> If I've read this correctly please find patch attached.
>
> BR,
>
> Jerry
>
> Signed-off-by: Jerry Evans g4 at novadsp.com
> ---
> docs/manual/customize-outside-br.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, I've applied your patch to master. However, I had to:
- Rewrite entirely the commit message, because yours contained some
irrelevant information for a commit log.
- Adjust your SoB line: your e-mail should have been enclosed in <...>
- Fix line wrapping in your patch. Please use 'git send-email' next
time to send your patch, and not Outlook.
Thanks for having reported and fixed this issue!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-20 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 13:28 [Buildroot] Possible documentation error and a patch jerry at chordia.co.uk
2016-11-20 14:55 ` Thomas Petazzoni [this message]
2016-11-20 15:20 ` jerry at chordia.co.uk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161120155502.28130680@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox