From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] qextserialport: fix static build
Date: Mon, 21 Nov 2016 21:41:25 +0100 [thread overview]
Message-ID: <20161121214125.2bb92b98@free-electrons.com> (raw)
In-Reply-To: <20161120221329.5827-4-arnout@mind.be>
Hello,
On Sun, 20 Nov 2016 23:13:29 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> By default, qextserialport will attempt to build a shared library.
> qesp_static has to be set in CONFIG to build static. Note that
> static+shared is not supported, in that case we just build shared.
>
> The install target commands also have to be gated in that case,
> because the *.so files don't exist. For completeness we both set
> QEXTSERIALPORT_INSTALL_STAGING to NO and don't define
> QEXTSERIALPORT_INSTALL_TARGET_CMDS for static builds, although one
> of them would be sufficient.
>
> Fixes:
> http://autobuild.buildroot.net/results/c9233ad71fd60d0e6a85731a8bd4e598bd84947a
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
It's a bit annoying that this comes late in the series. Some of the
rework in the previous patches are not technically needed to get this
build fix, and with the way your patch series is organized, we have to
merge more-or-less unrelated cleanups in master to get the build fix.
Patches 1/4 to 3/4 don't look too complicated, so maybe I'll merge.
I'll just wait and see if people agree or not.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-21 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 22:13 [Buildroot] [PATCH 1/4] qextserialport: define QEXTSERIALPORT_CONFIGURE_CMDS only once Arnout Vandecappelle
2016-11-20 22:13 ` [Buildroot] [PATCH 2/4] qextserialport: remove useless () around configure command Arnout Vandecappelle
2016-11-20 22:13 ` [Buildroot] [PATCH 3/4] qextserialport: use 'make install' to install to staging Arnout Vandecappelle
2016-11-21 20:39 ` Thomas Petazzoni
2016-11-20 22:13 ` [Buildroot] [PATCH 4/4] qextserialport: fix static build Arnout Vandecappelle
2016-11-21 20:41 ` Thomas Petazzoni [this message]
2016-11-21 20:53 ` Arnout Vandecappelle
2016-11-21 21:00 ` Thomas Petazzoni
2016-11-21 21:01 ` Arnout Vandecappelle
2016-11-21 21:49 ` [Buildroot] [PATCH 1/4] qextserialport: define QEXTSERIALPORT_CONFIGURE_CMDS only once Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121214125.2bb92b98@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox