Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] mplayer: disable for FLAT
Date: Mon, 21 Nov 2016 21:51:11 +0100	[thread overview]
Message-ID: <20161121215111.71ce807d@free-electrons.com> (raw)
In-Reply-To: <20161120164526.12576-1-arnout@mind.be>

Hello,

On Sun, 20 Nov 2016 17:45:26 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> mplayer uses a homegrown configure script that calls 'gcc -v | tail -1'
> to find the gcc version. However, our toolchain wrapper adds
> -Wl,-elf2flt to the gcc arguments. This triggers gcc to do an actual
> compile (rather than just printing version info and exiting), and that
> compile fails because of the missing definition of main(). The last
> line of the output is therefore:
> collect2: error: ld returned 1 exit status
> and configure doesn't find a version in there. It then falls back to
> using the host gcc instead, which breaks things completely a bit
> further down the line.
> 
> Since mplayer probably isn't very useful on noMMU architectures anyway,
> just disable it completely for FLAT.
> 
> Fixes:
> http://autobuild.buildroot.net/results/58cf28a3acd518633a1d8ea719bc70aefbdfb311
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v2: added the fixes line
> ---
>  package/mplayer/Config.in | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-11-21 20:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-20 16:45 [Buildroot] [PATCH v2] mplayer: disable for FLAT Arnout Vandecappelle
2016-11-21 20:51 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121215111.71ce807d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox