From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/2] cjson: bump to version v1.0.1
Date: Mon, 21 Nov 2016 23:21:21 +0100 [thread overview]
Message-ID: <20161121232121.56e3bc6e@free-electrons.com> (raw)
In-Reply-To: <1479662545-64029-1-git-send-email-fabrice.fontaine@orange.com>
Hello,
On Sun, 20 Nov 2016 18:22:24 +0100, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
An empty commit log for something that is clearly not a bump is not
good. You should explain that the project site has moved, why
BR2_STATIC_LIBS is OK, that it has changed to use cmake, etc.
Also your PATCH 2/2, also if it affects another package, should be
merged into PATCH 1/2. Indeed, if I ever apply PATCH 1/2 but not PATCH
2/2, tinycbor will not build.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-11-21 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 17:22 [Buildroot] [PATCH v2,1/2] cjson: bump to version v1.0.1 Fabrice Fontaine
2016-11-20 17:22 ` [Buildroot] [PATCH v2, 2/2] tinycbor: fix cjson include path and library name Fabrice Fontaine
2016-11-21 22:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121232121.56e3bc6e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox