From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] toolchain: simplify the conditions for BR2_TOOLCHAIN_ARM_HAS_SYNC_8
Date: Tue, 22 Nov 2016 09:35:15 +0100 [thread overview]
Message-ID: <20161122093515.6db0df30@free-electrons.com> (raw)
In-Reply-To: <20161121234340.30463-2-arnout@mind.be>
Hello,
On Tue, 22 Nov 2016 00:43:40 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> config BR2_TOOLCHAIN_ARM_HAS_SYNC_8
> bool
> default y
> depends on BR2_arm || BR2_armeb
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> - depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_ARM_CPU_ARMV7A
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
Can we make this instead:
depends on (BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 && BR2_TOOLCHAIN_USES_GLIBC) || BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
This way, glibc toolchains (which were never affected by the _write
issue) still expose the fact that they support the __sync_8 thing.
Otherwise, your change introduces a regression: a 4.7 glibc external
toolchain was prior to your patch exposing the fact that it supports
8-byte sync, but no longer after your patch.
Also, what about the __atomic 8 bytes? As we discussed yesterday, it's
in fact affected by the same issue. How do we deal with that? Do we
introduce per-size BR2_TOOLCHAIN_HAS_ATOMIC_<size> options?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-22 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 23:43 [Buildroot] [PATCH 1/2] gcc: backport upstream patch for sync_8 in !glibc Arnout Vandecappelle
2016-11-21 23:43 ` [Buildroot] [PATCH 2/2] toolchain: simplify the conditions for BR2_TOOLCHAIN_ARM_HAS_SYNC_8 Arnout Vandecappelle
2016-11-22 8:35 ` Thomas Petazzoni [this message]
2016-11-24 23:13 ` Arnout Vandecappelle
2016-11-25 8:56 ` Thomas Petazzoni
2016-12-08 21:44 ` Thomas Petazzoni
2016-11-26 14:27 ` [Buildroot] [PATCH 1/2] gcc: backport upstream patch for sync_8 in !glibc Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122093515.6db0df30@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox