Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Date: Thu, 24 Nov 2016 13:28:59 +0100	[thread overview]
Message-ID: <20161124132859.5d50267e@free-electrons.com> (raw)
In-Reply-To: <20161124112013.6u5setqv4gc3m7pc@tarshish>

Hello,

On Thu, 24 Nov 2016 13:20:13 +0200, Baruch Siach wrote:

> On Thu, Nov 24, 2016 at 04:56:42PM +1100, Sam Bobroff wrote:
> > Fixes next commit d634d9dda7f3c328d63469cb628c79da49a09e89.
> > 
> > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> > ---
> > Baruch,
> > 
> > I've rebased the patch onto next, I'm not sure what other changes to
> > make. Does it look OK now? (Will it get squashed in next?)  
> 
> The Buildroot maintainers do not rebase/amend next. When there is an issue 
> with an applied commit, either in next or master, post a but fix patch. Hence 
> the commit log should be more detailed. Also, you may mention the commit the 
> introduced the bug as you did, but not 'next'. The next branch will soon merge 
> into master, but the commit log will not change.

Sam: I thought your initial patch was not a bug fix, but a feature
addition, which is why I applied it to the "next" branch. However, I
see in the autobuilders failures of the host-qemu package for
powerpc64, and I believe those would be fixed by your patch. Could you
confirm it's the case? If it is, then I'll cherry-pick the original
patch (+ this additional fix) into the master branch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-24 12:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  5:56 [Buildroot] [PATCH 1/1] package/qemu: fixup enable host QEMU for powerpc64/powerpc64le Sam Bobroff
2016-11-24 11:20 ` Baruch Siach
2016-11-24 12:28   ` Thomas Petazzoni [this message]
2016-11-25  0:28     ` Sam Bobroff
2016-11-25 21:14 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124132859.5d50267e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox