From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 4/6] moarvm: select libffi when building for MIPS
Date: Thu, 24 Nov 2016 17:54:33 +0100 [thread overview]
Message-ID: <20161124175433.70488d2b@free-electrons.com> (raw)
In-Reply-To: <1d433e42-c4e9-ca80-0fd3-8c6223e0d13b@imgtec.com>
Hello,
On Thu, 24 Nov 2016 16:23:46 +0000, Vicente Olivert Riera wrote:
> no, there is no patch enabling or disabling MoarVM for MIPS. You won't
> be able to build MoarVM for MIPS until libatomic_ops has support for
> MIPS as well, because MoarVM depends on libatomic_ops.
>
> So, if we enable libatomic_ops, then we will be able to build MoarVM,
> and that will fail. What I did in my patch series is to add the code for
> fixing the MIPS problem in MoarVM even before we can actually build it
> for MIPS.
Ah, yes, moarvm has a "depends on
BR2_PACKAGE_LIBATOMIC_OPS_ARCH_SUPPORTS", so indeed moarvm can't be
selected for MIPS until MIPS support in libatomic_ops is enabled. So
bisectability-wise we are OK.
However, from a logical point of view, it is very, very strange to
enable the dependencies of moarvm *after* moarvm itself. It would be
much more logical to take care of libatomic_ops first (which can be
used for other things than moarvm), and then handle moarvm.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-24 16:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:39 [Buildroot] [PATCH next 1/6] moarvm: bump version to 2016.11 Vicente Olivert Riera
2016-11-23 14:39 ` [Buildroot] [PATCH next 2/6] moarvm: use pkgconfig to find libraries and headers Vicente Olivert Riera
2016-11-23 14:39 ` [Buildroot] [PATCH next 3/6] moarvm: enable optional support for libffi Vicente Olivert Riera
2016-11-23 14:39 ` [Buildroot] [PATCH next 4/6] moarvm: select libffi when building for MIPS Vicente Olivert Riera
2016-11-23 20:56 ` Thomas Petazzoni
2016-11-24 14:58 ` Vicente Olivert Riera
2016-11-24 15:21 ` Thomas Petazzoni
2016-11-24 16:23 ` Vicente Olivert Riera
2016-11-24 16:54 ` Thomas Petazzoni [this message]
2016-11-24 17:50 ` Vicente Olivert Riera
2016-11-23 14:39 ` [Buildroot] [PATCH next 5/6] libatomic_ops: add support for MIPS architecture Vicente Olivert Riera
2016-11-23 14:39 ` [Buildroot] [PATCH next 6/6] libatomic_ops: bump version to 7.4.4 Vicente Olivert Riera
2016-11-25 21:58 ` [Buildroot] [PATCH next 1/6] moarvm: bump version to 2016.11 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124175433.70488d2b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox