Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] m68k: add special gcc flag to avoid ICE for coldfire
Date: Sat, 26 Nov 2016 15:12:25 +0100	[thread overview]
Message-ID: <20161126151225.1eeaff6e@free-electrons.com> (raw)
In-Reply-To: <c7f2be5d-3849-d30b-bf39-731477bc1927@mind.be>

Hello,

On Sat, 26 Nov 2016 14:59:34 +0100, Arnout Vandecappelle wrote:

> > Hum, thanks but this patch you're pointing to is really material for
> > next at this point, so I cannot apply your patch, which should be
> > applied on master in order to fix the autobuilder issues.  
> 
>  Begging to differ: doing the same without patch 683830 would be a much bigger
> patch (adding yet another -D option to the wrapper, updating the wrapper
> itself). But OK, it's getting a bit later to still take _any_ risk, so probably
> the bigger patch is better.

That's my point: that late in the cycle, I don't want to touch too
many things around the toolchain wrapper. So adding one more CFLAGS or
LDFLAGS specific to m68k is OK (worst thing is a regression on m68k,
which probably isn't very widely used). But a change that touches the
toolchain wrapper, and can potentially break major architectures, I'm
not a big fan.

If nobody provides the bigger patch, I think I'm going to live with the
m68k autobuilder failures until the release, and merge afterwards.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-26 14:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-26  8:51 [Buildroot] [PATCH] m68k: add special gcc flag to avoid ICE for coldfire Waldemar Brodkorb
2016-11-26 10:47 ` Arnout Vandecappelle
2016-11-27 15:27   ` Waldemar Brodkorb
2016-11-26 13:52 ` Thomas Petazzoni
2016-11-26 13:59   ` Arnout Vandecappelle
2016-11-26 14:12     ` Thomas Petazzoni [this message]
2016-12-11 14:51     ` Thomas Petazzoni
2016-12-11 20:38       ` Arnout Vandecappelle
2017-03-10  9:23 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161126151225.1eeaff6e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox