Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 2/3] efivar: allow build with uClibc
Date: Sun, 27 Nov 2016 16:50:15 +0100	[thread overview]
Message-ID: <20161127165015.6cd4680d@free-electrons.com> (raw)
In-Reply-To: <20161127143204.116740-3-andriy.shevchenko@linux.intel.com>

Hello,

On Sun, 27 Nov 2016 16:32:03 +0200, Andy Shevchenko wrote:
> Details at https://github.com/rhinstaller/efivar/issues/76.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I've applied to next, but several things were wrong in there, see below.

> +++ b/package/efivar/0002-Allow-build-with-uClibc.patch
> @@ -0,0 +1,38 @@
> +From 2255601757a8a58baddad2d37d0bcc6b003a3732 Mon Sep 17 00:00:00 2001
> +From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> +Date: Fri, 25 Nov 2016 19:42:27 +0200
> +Subject: [PATCH 2/2] Allow build with uClibc

[PATCH] instead of [PATCH 2/2].

Also, please submit this patch upstream if not already done.

> diff --git a/package/efivar/Config.in b/package/efivar/Config.in
> index 466a30a..5fd3360 100644
> --- a/package/efivar/Config.in
> +++ b/package/efivar/Config.in
> @@ -11,7 +11,6 @@ config BR2_PACKAGE_EFIVAR
>  		!BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII
>  	# doesn't build with uclibc due to lack of uchar.h
>  	# doesn't build with musl due to lack of __bswap_constant_16
> -	depends on BR2_TOOLCHAIN_USES_GLIBC

Then what about musl? The build on musl continues to fail, so I've
changed this to:

	depends on !BR2_TOOLCHAIN_USES_MUSL

>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>  	select BR2_PACKAGE_POPT
>  	help
> @@ -21,7 +20,6 @@ config BR2_PACKAGE_EFIVAR
>  
>  comment "efivar requires a glibc toolchain w/ headers >= 3.12, gcc >= 4.9"

You forgot to update this comment, so I did it.

>  	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
> -		!BR2_TOOLCHAIN_USES_GLIBC || \

And I changed this to:
		BR2_TOOLCHAIN_USES_MUSL || \

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-27 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27 14:32 [Buildroot] [PATCH v1 0/3] efibootmgr: build with uClibc Andy Shevchenko
2016-11-27 14:32 ` [Buildroot] [PATCH v1 1/3] efivar: bump to version 30 Andy Shevchenko
2016-11-27 15:48   ` Thomas Petazzoni
2016-11-27 14:32 ` [Buildroot] [PATCH v1 2/3] efivar: allow build with uClibc Andy Shevchenko
2016-11-27 15:50   ` Thomas Petazzoni [this message]
2016-11-27 14:32 ` [Buildroot] [PATCH v1 3/3] efibootmrg: Allow " Andy Shevchenko
2016-11-27 15:51   ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2016-11-28 16:35 [Buildroot] [PATCH v1 0/3] efibootmgr: " Andy Shevchenko
2016-11-28 16:35 ` [Buildroot] [PATCH v1 2/3] efivar: allow " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161127165015.6cd4680d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox