From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Makefile: drop redundant shell call when deriving BASE_DIR
Date: Sun, 27 Nov 2016 23:16:46 +0100 [thread overview]
Message-ID: <20161127231646.4d998029@free-electrons.com> (raw)
In-Reply-To: <1479868291-2863-1-git-send-email-danomimanchego123@gmail.com>
Hello,
On Tue, 22 Nov 2016 21:31:31 -0500, Danomi Manchego wrote:
> Commit 173135df5b69dfd5ae6fe6cf2de8833c6f74c143 ("core: re-enter make if
> $(CURDIR) or $(O) are not canonical paths") introduced the CANONICAL_O
> variable, defined as:
>
> CANONICAL_O := $(shell mkdir -p $(O) >/dev/null 2>&1)$(realpath $(O))
>
> This duplicates the definition of BASE_DIR, by different means:
>
> BASE_DIR := $(shell mkdir -p $(O) && cd $(O) >/dev/null && pwd)
>
> So one of these shell calls is redundant. CANONICAL_O is defined first,
> so this commit replaces the BASE_DIR derivation with $(CANONICAL_O).
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
> Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-11-27 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 2:31 [Buildroot] [PATCH 1/1] Makefile: drop redundant shell call when deriving BASE_DIR Danomi Manchego
2016-11-27 22:16 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161127231646.4d998029@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox