Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] postgresql: fix pgac_cv_snprintf_long_long_int_modifier
Date: Mon, 28 Nov 2016 21:17:05 +0100	[thread overview]
Message-ID: <20161128211705.62dee464@free-electrons.com> (raw)
In-Reply-To: <20161128192901.www7lldws5fvneki@tarshish>

Hello,

On Mon, 28 Nov 2016 21:29:01 +0200, Baruch Siach wrote:
> Hi Peter,
> 
> On Mon, Nov 28, 2016 at 07:53:51PM +0100, Peter Seiderer wrote:
> > Supplementary change the pgac_cv_snprintf_long_long_int_modifier from
> > complete format '%lld' to modifier 'll' version only (forgotten in commit
> > 02c43157ab09f6fe4078fd1145fc9d403d66c089 ([1])).  
> 
> The original commit that introduced pgac_cv_snprintf_long_long_int_format 
> caching (3d3f70b5677, postgresql: avoid AC_TRY_RUN when testing snprintf()) 
> did so because of AC_TRY_RUN calls. These were removed in upstream commit 
> a2edb023d [1]. It is most likely safe to remove these cached values now.
> 
> [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a2edb023d08778c3346bbbf4ca82ef7f6e9283eb

I don't see anything in this commit that removes the AC_TRY_RUN()
checks. It replaces the AC_TRY_RUN() checks by AC_RUN_IFELSE(), which
is doing exactly the same: a runtime test. What makes you think this
commit solves the problem?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-11-28 20:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 18:53 [Buildroot] [PATCH v1] postgresql: fix pgac_cv_snprintf_long_long_int_modifier Peter Seiderer
2016-11-28 19:29 ` Baruch Siach
2016-11-28 20:17   ` Thomas Petazzoni [this message]
2016-11-28 20:27     ` Peter Seiderer
2016-11-28 20:40 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128211705.62dee464@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox