From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/10] core: add waf-package infra
Date: Fri, 2 Dec 2016 23:56:56 +0100 [thread overview]
Message-ID: <20161202235656.2bd6d029@free-electrons.com> (raw)
In-Reply-To: <6556713514fd3c751384c5ea655420dba5e8876a.1477843328.git.yann.morin.1998@free.fr>
Hello,
On Sun, 30 Oct 2016 17:02:13 +0100, Yann E. MORIN wrote:
> +# If the package does not have its own waf, use our own.
> +ifeq ($$($(2)_BUNDLED_WAF),NO)
I've renamed this variable to _NEEDS_EXTERNAL_WAF, which inverts its
logic. It's explicitly defined to NO by default, and when set to YES, a
dependency on host-waf is needed.
> +# Dependency on host-python is done by host-waf
> +$(2)_DEPENDENCIES += host-waf
> +$(2)_WAF = $(HOST_DIR)/usr/bin/waf
> +else
> +# We need host-python to run the package's waf
> +$(2)_DEPENDENCIES += host-python
This line has been moved out of the condition, since it's now needed
for both the "bundled waf" and "external waf" cases.
> +ifndef $(2)_MAKE
> + ifdef $(3)_MAKE
> + $(2)_MAKE = $$($(3)_MAKE)
> + else
> + $(2)_MAKE ?= $$(MAKE)
> + endif
> +endif
I've dropped this as it wasn't needed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-02 22:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 16:02 [Buildroot] [PATCH 00/10] core: add waf-package infra, convert packages Yann E. MORIN
2016-10-30 16:02 ` [Buildroot] [PATCH 01/10] package/waf: new host package Yann E. MORIN
2016-10-30 16:21 ` Romain Naour
2016-12-02 22:55 ` Thomas Petazzoni
2016-10-30 16:02 ` [Buildroot] [PATCH 02/10] core: add waf-package infra Yann E. MORIN
2016-10-30 16:30 ` Romain Naour
2016-11-16 23:02 ` Thomas Petazzoni
2016-11-17 20:44 ` Yann E. MORIN
2016-11-17 23:54 ` Arnout Vandecappelle
2016-11-17 23:52 ` Arnout Vandecappelle
2016-11-18 8:45 ` Thomas Petazzoni
2016-11-25 7:16 ` Lionel Orry
2016-12-02 22:56 ` Thomas Petazzoni [this message]
2016-10-30 16:02 ` [Buildroot] [PATCH 03/10] docs/manual: document the " Yann E. MORIN
2016-10-30 16:31 ` Romain Naour
2016-11-16 23:04 ` Thomas Petazzoni
2016-11-17 20:47 ` Yann E. MORIN
2016-11-18 8:46 ` Thomas Petazzoni
2016-12-02 22:57 ` Thomas Petazzoni
2016-10-30 16:02 ` [Buildroot] [PATCH 04/10] developpers: add myself as pkg-waf devel Yann E. MORIN
2016-10-30 16:31 ` Romain Naour
2016-10-30 16:02 ` [Buildroot] [PATCH 05/10] package/glmark2: make it a waf-package Yann E. MORIN
2016-10-30 16:33 ` Romain Naour
2016-10-30 16:02 ` [Buildroot] [PATCH 06/10] package/gst1-imx: " Yann E. MORIN
2016-10-30 16:35 ` Romain Naour
2016-11-01 10:52 ` Gary Bisson
2016-10-30 16:02 ` [Buildroot] [PATCH 07/10] package/jack2: " Yann E. MORIN
2016-10-30 16:38 ` Romain Naour
2016-10-30 16:02 ` [Buildroot] [PATCH 08/10] package/libimxvpuapi: " Yann E. MORIN
2016-10-30 16:39 ` Romain Naour
2016-11-01 10:52 ` Gary Bisson
2016-10-30 16:02 ` [Buildroot] [PATCH 09/10] package/mpv: " Yann E. MORIN
2016-11-02 22:42 ` Romain Naour
2016-12-02 22:58 ` Thomas Petazzoni
2016-10-30 16:02 ` [Buildroot] [PATCH 10/10] package/norm: " Yann E. MORIN
2016-10-30 16:40 ` Romain Naour
2016-10-30 16:12 ` [Buildroot] [PATCH 00/10] core: add waf-package infra, convert packages Romain Naour
2016-12-02 22:55 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202235656.2bd6d029@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox