From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2016-12-02
Date: Sun, 4 Dec 2016 15:11:45 +0100 [thread overview]
Message-ID: <20161204151145.0a309442@free-electrons.com> (raw)
In-Reply-To: <20161203233249.08ff4c7b@gmx.net>
Hello,
Adding in Cc: Waldemar for Microblaze, and Max for Xtensa.
On Sat, 3 Dec 2016 23:32:49 +0100, Peter Seiderer wrote:
> +#if defined(__alpha__) || defined(__arm__) || defined(__aarch64__) || defined(__bfin) || defined(__hppa__) || defined(__mips__) || defined(__sh__) || defined(__sparc__) || defined(__sparc) || defined(__ia64__) || defined(_M_ALPHA) || defined(_M_ARM) || defined(_M_IA64)
> +# define GST_HAVE_UNALIGNED_ACCESS 0
> +#elif defined(__i386__) || defined(__i386) || defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__ppc__) || defined(__ppc64__) || defined(__m68k__) || defined(_M_IX86) || defined(_M_AMD64) || defined(_M_X64)
> +# define GST_HAVE_UNALIGNED_ACCESS 1
> +#else
> +# error "Could not detect architecture; don't know whether it supports unaligned access! Please file a bug."
> +#endif
>
> Time to add defines for microblazeel and xtensa, any hint which defines and at
> unaligned acess yes/no?
Do you think there would be a problem to simply assume by default that
the architecture doesn't support unaligned accesses? I mean, if a new
architecture by chance supports unaligned accesses, but we tell
GStreamer that we don't support such unaligned accesses, what can go
wrong? Possibly the code is slightly less efficient, but there should
be no runtime issue.
So what about instead doing:
#if defined(__i386__) || defined(__i386) || defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__ppc__) || defined(__ppc64__) || defined(__m68k__) || defined(_M_IX86) || defined(_M_AMD64) || defined(_M_X64)
# define GST_HAVE_UNALIGNED_ACCESS 1
#else
# define GST_HAVE_UNALIGNED_ACCESS 0
#endif
and be done with it?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-04 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 7:30 [Buildroot] [autobuild.buildroot.net] Build results for 2016-12-02 Thomas Petazzoni
2016-12-03 22:32 ` Peter Seiderer
2016-12-04 14:11 ` Thomas Petazzoni [this message]
2016-12-05 3:29 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204151145.0a309442@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox