Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/openpowerlink: bump to v2.5.0
Date: Sun, 4 Dec 2016 23:59:28 +0100	[thread overview]
Message-ID: <20161204235928.5ba9426f@free-electrons.com> (raw)
In-Reply-To: <1478207123-27787-1-git-send-email-romain.naour@gmail.com>

Hello,

On Thu,  3 Nov 2016 22:05:22 +0100, Romain Naour wrote:
> From: Romain Naour <romain.naour@smile.fr>
> 
>  - Rebase existing patches
>  - Use a "menu" instead of "choice" to select Ethernet Powerlink
>    Drivers since we can now build several kernel modules at once.
>  - Select the Intel 82573 driver by default.
>  - Disable library with simulation interface.
>  - Disable zynq/FPGA (PCIe) interface otherwise the kernelpcp library
>    is always build.
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>

I've applied, after doing one small change, see below.


> -choice
> -	prompt "select Ethernet Powerlink Driver"
> +menu "select Ethernet Powerlink Driver"

Just "Ethernet drivers" was enough.

 - "select" is useless, options are obviously meant to be selected

 - powerlink is already the name of the package (or close to)

 - driver should be drivers, since we can now select more than one

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-12-04 22:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 21:05 [Buildroot] [PATCH 1/2] package/openpowerlink: bump to v2.5.0 Romain Naour
2016-11-03 21:05 ` [Buildroot] [PATCH 2/2] package/openpowerlink: fix build with Linux kernel 4.7+ Romain Naour
2016-12-04 22:59   ` Thomas Petazzoni
2016-12-04 22:59 ` Thomas Petazzoni [this message]
2016-12-05 19:42   ` [Buildroot] [PATCH 1/2] package/openpowerlink: bump to v2.5.0 Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161204235928.5ba9426f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox