Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] nginx-dav-ext: New package
Date: Mon, 5 Dec 2016 14:33:22 +0100	[thread overview]
Message-ID: <20161205143322.227297e2@free-electrons.com> (raw)
In-Reply-To: <CAJtjsKayVVJBRf+v1PYnL1hb6D5FqfqC1Y3pb9fGnkybf3bpAA@mail.gmail.com>

Hello,

On Mon, 5 Dec 2016 14:20:43 +0100, Johan Oudinet wrote:

> Indeed, you have moved this module outside the HTTP modules:
> ifeq ($(BR2_PACKAGE_NGINX_HTTP),y)
> ...
> endif # BR2_PACKAGE_NGINX_HTTP
> 
> So now, linking fails if BR2_PACKAGE_NGINX_HTTP is not set.
> Should I rename this package to nginx-http-dav-ext to indicate it must
> be compiled with the HTTP server of nginx?

Hum, and the problem is I guess the same for the naxsi module. Renaming
the package name is not necessary, we should handle this using
dependencies.

The previous solution used for the nginx-naxsi package was not good,
because you could select BR2_PACKAGE_NGINX_NAXSI, but if
BR2_PACKAGE_NGINX_HTTP was disabled, in fact the naxsi module was not
built.

So instead, I believe that nginx-naxsi/Config.in and
nginx-dav-ext/Config.in should contain a:

	depends on BR2_PACKAGE_NGINX_HTTP

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-12-05 13:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 16:47 [Buildroot] [PATCH 1/1] nginx-dav-ext: New package Johan Oudinet
2016-12-01 10:34 ` Johan Oudinet
2016-12-04 22:52 ` Thomas Petazzoni
2016-12-05 10:58   ` Johan Oudinet
2016-12-05 11:14     ` Thomas Petazzoni
2016-12-05 13:20       ` Johan Oudinet
2016-12-05 13:33         ` Thomas Petazzoni [this message]
2016-12-05 13:41           ` Johan Oudinet
2016-12-05 13:53             ` Thomas Petazzoni
2016-12-05 14:31               ` Johan Oudinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205143322.227297e2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox