From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Wed, 7 Dec 2016 11:24:26 +0100
Subject: [Buildroot] [PATCH] package/reactcpp: new package
In-Reply-To: <74b2df33-0865-c6b6-d731-f0e9191223b9@grinn-global.com>
References: <20161206132643.27141-1-m.niestroj@grinn-global.com>
 <20161206163136.23d44f9f@free-electrons.com>
 <74b2df33-0865-c6b6-d731-f0e9191223b9@grinn-global.com>
Message-ID: <20161207112426.5b40788d@free-electrons.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello,

On Wed, 7 Dec 2016 10:59:09 +0100, Marcin Niestroj wrote:

> > Just define the version as v$(REACTCPP_VERSION_MAJOR).3  
> 
> I am using $(REACTCPP_VERSION_RAW) below to define $(REACTCPP_SO).

Yes, but REACTCPP_SO is useless, see below.

> >> +ifeq ($(BR2_STATIC_LIBS),)
> >> +define REACTCPP_INSTALL_TARGET_CMDS
> >> +	$(INSTALL) -D -m 0755 $(@D)/src/$(REACTCPP_SO) $(TARGET_DIR)/usr/lib/$(REACTCPP_SO)
> >> +	ln -sf $(REACTCPP_SO) $(TARGET_DIR)/usr/lib/libreactcpp.so.$(REACTCPP_VERSION_MAJOR)
> >> +	ln -sf $(REACTCPP_SO) $(TARGET_DIR)/usr/lib/libreactcpp.so
> >> +endef
> >> +endif  
> >
> > Why are you doing this instead of calling "make install" for
> > $(TARGET_DIR) ?  
> 
> Because make install also copies header files and static library.

And that's perfectly fine. Just let "make install" install header files
and static library. Buildroot will clean them up at the end of the
build, in the "target-finalize" step.

It's much, much better (and future proof) to use the build system of the
package itself when possible, and rely on target-finalize to clean
things up at the end of the build.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com