From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] usbip: add a new package
Date: Tue, 13 Dec 2016 18:35:24 +0100 [thread overview]
Message-ID: <20161213173524.GA3546@free.fr> (raw)
In-Reply-To: <CAFDyS3P=SMKSnoBi5QFR=PrTTsNiOK05yeAEdw7OHVW-D5Z1qA@mail.gmail.com>
Tal, All,
On 2016-12-13 00:17 +0200, Tal Shorer spake thusly:
> On Mon, Dec 12, 2016 at 7:25 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > Tal, Arnout, All,
> >
> > On 2016-12-12 10:40 +0100, Arnout Vandecappelle spake thusly:
> >> On 11-12-16 23:30, Tal Shorer wrote:
> >> > Both don't deal with source-check, though. I think we should consider
> >> > linux-tools again at this point, since it doesn't have any of these
> >> > problems (it has its own problems, but I'm beginning to think I'd
> >> > rather deal with those). If nobody objects to this approach I'll
> >>
> >> +1 to that approach.
> >
> > Still, I don't like the custom autotools commands we'll have to have.
> > What about (mock-up, just for the sake of the example):
> >
> > ###############
> > # usbip
> > ###############
> >
> > # No USBIP_SITE, no USB_VERSION, we vampirise the code from the
> > # linux kernel
> > USBIP_PATCH_DEPENDENCIES = linux
> >
> > USBIP_SRC_DIR = $)(wildcard \
> > $(LINUX_DIR)/tools/usb/usbip \
> > $(LINUX_DIR)/drivers/staging/blabla)
> >
> > define USBIP_EXTRACT_CMDS
> > if [ -z "$(USB_SRC_DIR)" ]; then \
> > echo "No usbip source in your kernel tree" 2>&1; \
> > exit 1; \
> > fi
> > rsync $(USB_SRC_DIR) $(@D)
> > endef
> >
> > $(eval $(autotools-package))
> >
> > This way, we still have a proper autotools package, we don;t fail on
> > source-check, and we re-use the kernel sources.
> This works after some modifications.
Yes, it was definitely buggy, it was just a mock-up...
> We end up duplicating the rsync
> command from pkg-generic, but the argument that this is better than
> duplicating the configure command is easily made.
Yes, the rsync command is duplicated, but that one is easier to maintain
than the autotools commands (configure, build, target-install, and
staging-isntall).
> I'll send a new patch
Thanks, I'll review it now.
Regards,
Yann E. MORIN.
> >
> > Regards,
> > Yann E. MORIN.
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> > '------------------------------^-------^------------------^--------------------'
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-12-13 17:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 8:37 [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-10 13:31 ` Thomas Petazzoni
2016-12-10 18:39 ` Tal Shorer
2016-12-11 10:06 ` Yann E. MORIN
2016-12-11 13:56 ` Yann E. MORIN
2016-12-11 17:39 ` Tal Shorer
2016-12-11 17:45 ` Yann E. MORIN
2016-12-11 18:12 ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Tal Shorer
2016-12-11 19:19 ` Yann E. MORIN
2016-12-11 19:44 ` [Buildroot] [PATCH] package/usbip: new package Tal Shorer
2016-12-17 15:00 ` [Buildroot] [PATCH] pkg-generic: run $(PKG)_PRE_RSYNC_HOOKS before checking for the existence of $(SRCDIR) Thomas Petazzoni
2016-12-11 18:31 ` [Buildroot] [PATCH] usbip: add a new package Tal Shorer
2016-12-11 19:24 ` Yann E. MORIN
2016-12-11 19:59 ` Arnout Vandecappelle
2016-12-11 21:40 ` Yann E. MORIN
2016-12-11 21:46 ` Tal Shorer
2016-12-11 22:05 ` Yann E. MORIN
2016-12-11 22:11 ` Tal Shorer
2016-12-11 22:20 ` Yann E. MORIN
2016-12-11 22:30 ` Tal Shorer
2016-12-12 9:40 ` Arnout Vandecappelle
2016-12-12 17:25 ` Yann E. MORIN
2016-12-12 22:17 ` Tal Shorer
2016-12-12 22:21 ` [Buildroot] [PATCH v3] usbip: " Tal Shorer
2016-12-13 17:53 ` Yann E. MORIN
2016-12-14 17:28 ` [Buildroot] [PATCH v4] " Tal Shorer
2016-12-21 22:17 ` Tal Shorer
2016-12-22 20:45 ` Yann E. MORIN
2016-12-23 18:24 ` Yann E. MORIN
2016-12-23 19:10 ` Yann E. MORIN
2016-12-13 17:35 ` Yann E. MORIN [this message]
2016-12-12 17:09 ` [Buildroot] [PATCH v2 1/2] package: linux-tools: allow tools to define configure hooks Tal Shorer
2016-12-12 17:09 ` [Buildroot] [PATCH v2 2/2] package: linux-tools: add usbip Tal Shorer
2016-12-12 17:26 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213173524.GA3546@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox