[Buildroot] [PATCH 1/1] gst1-vaapi: new package

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

Thanks for this contribution!

On Thu, 15 Dec 2016 15:53:51 +0100, Jesper B?kdahl wrote:
> --- /dev/null
> +++ b/package/gstreamer1/gst1-vaapi/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_GST1_VAAPI
> +	bool "gst1-vaapi"
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_GST1_PLUGINS_BAD

Are you sure you need those set of plugins to be built to build the
gst1-vaapi plugin? I'm not too familiar with GStreamer, so maybe this
is correct, but it looks strange.

> +	select BR2_PACKAGE_GST1_PLUGINS_LIBVA
> +	select BR2_PACKAGE_GST1_PLUGINS_LIBDRM

These two lines however are clearly wrong: those symbols don't exist in
Buildroot. And your .mk file has a dependency on libva and libdrm
instead. So these should be:

	select BR2_PACKAGE_LIBVA
	select BR2_PACKAGE_LIBDRM

However, you need to inherit the dependencies of those packages:

        depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm/libpthread-stubs
        depends on !BR2_STATIC_LIBS

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com