Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v4 0/4] mariadb: new package
Date: Sat, 17 Dec 2016 15:04:38 +0100	[thread overview]
Message-ID: <20161217150438.0172072e@free-electrons.com> (raw)
In-Reply-To: <20161216222654.23747-1-bluemrp9@gmail.com>

Hello,

On Fri, 16 Dec 2016 14:26:50 -0800, Ryan Coe wrote:
> This patch series represents my attempt to add MariaDB 10.1 to Buildroot.
> Based on feedback, this series does three things.  First, the old mysql package
> is renamed to oracle-mysql.  Second, mariadb is added as a new package.  Third,
> mysql is converted to a virtual package.  I have tested this on arm and x86_64
> with uclibc and glibc.

Thanks a lot, I've applied your patch series. However, before doing so,
I did a few changes. Indeed, with your patch series, after PATCH 1, but
before PATCH 4, all packages in Buildroot that did depend or select
BR2_PACKAGE_MYSQL would have been broken.

To keep things bisectable, here is what I have done:

 - Move the patch introducing mariadb as the first patch. I adjusted
   the "depends on !BR2_PACKAGE_ORACLE_MYSQL" to "depends
   on !BR2_PACKAGE_MYSQL".

 - Merge the patches renaming mysql to oracle-mysql and moving it to a
   virtual package (also offering mariadb).

I did some quick built tests, and it also went fine. Let's monitor the
autobuilders in the next days to see if anything breaks.

However, it is good to remind you that since mariadb is only selected
through a choice and is not the default, it will never be chosen by the
autobuilders (due to a Kconfig issue, choices are not randomized in our
autobuilder testing).

Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2016-12-17 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16 22:26 [Buildroot] [RFC v4 0/4] mariadb: new package Ryan Coe
2016-12-16 22:26 ` [Buildroot] [RFC v4 1/4] mysql: rename package to oracle-mysql Ryan Coe
2016-12-16 22:26 ` [Buildroot] [RFC v4 2/4] mariadb: new package Ryan Coe
2016-12-16 22:26 ` [Buildroot] [RFC v4 3/4] DEVELOPERS: add entry for mariadb Ryan Coe
2016-12-16 22:26 ` [Buildroot] [RFC v4 4/4] mysql: convert to virtual package Ryan Coe
2016-12-17 14:04 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161217150438.0172072e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox