From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package
Date: Sat, 17 Dec 2016 16:14:56 +0100 [thread overview]
Message-ID: <20161217161456.7b333157@free-electrons.com> (raw)
In-Reply-To: <1480263400-29605-1-git-send-email-romain.naour@gmail.com>
Hello,
On Sun, 27 Nov 2016 17:16:38 +0100, Romain Naour wrote:
> +define LINUX_SYSCALL_SUPPORT_HOST_INSTALL
> + $(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
> + $(HOST_DIR)/usr/include/linux_syscall_support.h
> +endef
> +HOST_LINUX_SYSCALL_SUPPORT_POST_INSTALL_HOOKS += LINUX_SYSCALL_SUPPORT_HOST_INSTALL
> +
> +define LINUX_SYSCALL_SUPPORT_STAGING_INSTALL
> + $(INSTALL) -D -m 0644 $(@D)/linux_syscall_support.h \
> + $(STAGING_DIR)/usr/include/linux_syscall_support.h
> +endef
> +LINUX_SYSCALL_SUPPORT_POST_INSTALL_STAGING_HOOKS += LINUX_SYSCALL_SUPPORT_STAGING_INSTALL
There was no reason to use post-install hooks here. Instead,
implementing directly LINUX_SYSCALL_SUPPORT_INSTALL_STAGING_CMDS and
HOST_LINUX_SYSCALL_SUPPORT_INSTALL_CMDS makes a lot more sense, since
it's a generic-package.
I've applied after fixing this, and adding a follow-up commit adding
you to the DEVELOPERS flie for this package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-12-17 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 16:16 [Buildroot] [PATCH for-next 1/3] package/linux-syscall-support: new package Romain Naour
2016-11-27 16:16 ` [Buildroot] [PATCH for-next 2/3] package/google-breakpad: switch to the new git repository Romain Naour
2016-11-28 19:37 ` Romain Naour
2016-12-17 15:33 ` Thomas Petazzoni
2017-05-28 18:14 ` Bernd Kuhls
2017-05-28 18:51 ` Romain Naour
2017-05-28 20:17 ` Thomas Petazzoni
2016-11-27 16:16 ` [Buildroot] [PATCH for-next 3/3] package/google-breakpad: bump to the latest version Romain Naour
2016-12-17 15:34 ` Thomas Petazzoni
2016-12-17 15:14 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217161456.7b333157@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox