Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3,3/3] soletta: new package
Date: Mon, 19 Dec 2016 23:12:08 +0100	[thread overview]
Message-ID: <20161219231208.46c66492@free-electrons.com> (raw)
In-Reply-To: <1482101300-9180-3-git-send-email-fabrice.fontaine@orange.com>

Hello,

On Sun, 18 Dec 2016 23:48:20 +0100, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>

I'm sorry, but this still doesn't work with old make versions. I get:

make[1]: Entering directory `/home/test/buildroot/output/build/soletta-v1'
Makefile.smallos:35: "LDFLAGS not set. This is probably an error"
Makefile.smallos:57: *** multiple target patterns.  Stop.
make[1]: Leaving directory `/home/test/buildroot/output/build/soletta-v1'

This is due to the := assignments in the target definitions. If I change:

$(soletta_target): private export BOARD_NAME:=$(BOARD_NAME)
$(soletta_config): private export BOARD_NAME:=$(BOARD_NAME)

to

$(soletta_target): private export BOARD_NAME=$(BOARD_NAME)
$(soletta_config): private export BOARD_NAME=$(BOARD_NAME)

then a different problem happens: the "private" keyword apparently
didn't exist in make 3.81, and therefore is interpreted as being a
target, and therefore:

make[1]: Entering directory `/home/test/buildroot/output/build/soletta-v1'
Makefile.smallos:35: "LDFLAGS not set. This is probably an error"
make[1]: *** No rule to make target `private', needed by `/home/test/buildroot/output/build/soletta-v1/.config'.  Stop.
make[1]: Leaving directory `/home/test/buildroot/output/build/soletta-v1'

So, really, this package that requires a brand new version of make, and
python3, is a bit annoying in terms of build process... Maybe this is
something you can work out with upstream?

In the mean time, we cannot apply this, as it will badly fail on our
autobuilders, and for many of our users who run fairly old systems.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-12-19 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18 22:48 [Buildroot] [PATCH v3,1/3] python-vcversioner: new package Fabrice Fontaine
2016-12-18 22:48 ` [Buildroot] [PATCH v3,2/3] python-jsonschema: " Fabrice Fontaine
2016-12-18 22:48 ` [Buildroot] [PATCH v3,3/3] soletta: " Fabrice Fontaine
2016-12-19 22:12   ` Thomas Petazzoni [this message]
2016-12-19 22:25     ` Fabrice Fontaine
2016-12-19 22:36       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161219231208.46c66492@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox