Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] quagga: Create /var/run/quagga on sysv
Date: Wed, 21 Dec 2016 10:03:24 +0100	[thread overview]
Message-ID: <20161221100324.0f4c89e0@free-electrons.com> (raw)
In-Reply-To: <1482293253-61002-1-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

Thanks for this patch!

On Tue, 20 Dec 2016 22:07:33 -0600, Matt Weber wrote:

> diff --git a/package/quagga/S99quagga b/package/quagga/S99quagga
> new file mode 100644
> index 0000000..e964387
> --- /dev/null
> +++ b/package/quagga/S99quagga
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +
> +if [ ! -d /var/run/quagga ]; then
> +       mkdir -p /var/run/quagga
> +       chown quagga:quagga /var/run/quagga
> +fi

I think we would prefer to have a real init script, that not only
creates /var/run/quagga, but also starts quagga itself. I.e something
that does the same as the systemd unit file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-12-21  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  4:07 [Buildroot] [PATCH] quagga: Create /var/run/quagga on sysv Matt Weber
2016-12-21  9:03 ` Thomas Petazzoni [this message]
2016-12-21  9:14   ` Peter Korsgaard
2016-12-22 14:21     ` Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161221100324.0f4c89e0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox