From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] python-protobuf: Allow host building
Date: Sun, 15 Jan 2017 22:30:47 +0100 [thread overview]
Message-ID: <20170115213047.GC4277@free.fr> (raw)
In-Reply-To: <20170112191523.23814-2-wak@google.com>
William, All,
On 2017-01-12 11:15 -0800, William A. Kennington III spake thusly:
> Currently python-protobuf does not allow be built as a host package
> during a cross compile. We would like to be able to build nanopb as a
> host package but can't without host-python-protobuf.
>
> Signed-off-by: William A. Kennington III <wak@google.com>
> ---
> package/python-protobuf/python-protobuf.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
> index d8be76dd7..d46bda243 100644
> --- a/package/python-protobuf/python-protobuf.mk
> +++ b/package/python-protobuf/python-protobuf.mk
> @@ -13,4 +13,5 @@ PYTHON_PROTOBUF_DEPENDENCIES = host-protobuf
> PYTHON_PROTOBUF_SETUP_TYPE = setuptools
> PYTHON_PROTOBUF_SUBDIR = python
>
> +$(eval $(host-python-package))
> $(eval $(python-package))
This is not documented (AFAIK), but the host variant must go after the
target variant. Otherwise, strange things can happen (because of the way
variables have default values that depend on the order of evaluation,
like the source archive for example).
Note: this is valid for the following patch as awell, of course.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-01-15 21:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 1:13 [Buildroot] [PATCH 0/3] pblog: Add new package William A. Kennington III
2016-12-09 1:13 ` [Buildroot] [PATCH 1/3] python-protobuf: Allow host building William A. Kennington III
2016-12-10 14:38 ` Thomas Petazzoni
2016-12-09 1:13 ` [Buildroot] [PATCH 2/3] nanopb: Init at 69e9c1fc8162956feffa32e07a97c53bdb92f5ef William A. Kennington III
2016-12-10 14:37 ` Thomas Petazzoni
2016-12-09 1:13 ` [Buildroot] [PATCH 3/3] pblog: Init at e2e17544950eedac4f3bc59926aed8604d755072 William A. Kennington III
2016-12-10 14:41 ` Thomas Petazzoni
2017-01-12 19:15 ` [Buildroot] [PATCH v2 0/3] pblog: new package William A. Kennington III
2017-01-12 19:15 ` [Buildroot] [PATCH v2 1/3] python-protobuf: Allow host building William A. Kennington III
2017-01-15 21:30 ` Yann E. MORIN [this message]
2017-01-17 22:09 ` Arnout Vandecappelle
2017-01-15 21:32 ` Yann E. MORIN
2017-01-12 19:15 ` [Buildroot] [PATCH v2 2/3] nanopb: new package William A. Kennington III
2017-01-15 21:51 ` Yann E. MORIN
2017-01-18 18:59 ` William Kennington
2017-01-12 19:15 ` [Buildroot] [PATCH v2 3/3] pblog: " William A. Kennington III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170115213047.GC4277@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox