From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 17 Jan 2017 16:44:37 +1100 Subject: [Buildroot] [PATCH v2] util-linux: fix ncurses/wchar handling (again) In-Reply-To: <1484301833-16403-1-git-send-email-casantos@datacom.ind.br> References: <1484281849-25875-1-git-send-email-casantos@datacom.ind.br> <1484301833-16403-1-git-send-email-casantos@datacom.ind.br> Message-ID: <20170117164437.36272eed@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 13 Jan 2017 08:03:53 -0200, Carlos Santos wrote: > util-linux #defines "wchar_t" as "char" when configured without widechar > support. This conflicts with definition of wchar_t contained in stddef.h, > so the compilation fails with > > error: two or more data types in declaration specifiers > #define > wchar_t char > > The error can be avoided by rearranging the inclusion order in some files > under the text-utils directory. > > Fixes: > > http://autobuild.buildroot.net/results/3a2f228e0fa7b5cc28a13d49f48f1a6aef8d9d7a > http://autobuild.buildroot.net/results/99e96069f652d511c6212a5bb6be29e68fb1747c > http://autobuild.buildroot.net/results/2dc5721aef93b7b410153bafad78248fac3db941 > > Signed-off-by: Carlos Santos I tried to fix the same problem in commit 5a18eabdf08564688761a9b2f35892d69d8f9a18, but apparently failed at taking into account all the possible situations. So if we are going to merge a different solution, I'd like to see an investigation of whether commit 5a18eabdf08564688761a9b2f35892d69d8f9a18 is still needed or not. If it's not, then it should be reverted as well. I must say I find the fix of playing with the ordering of includes to be somewhat hackish. Do we have a better solution? Is it really legal for util-linux to redefine wchar_t? Should it use a better autoconf check before doing this? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com