From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nodejs: unbreak 0.10.x host build
Date: Mon, 23 Jan 2017 19:07:29 +1100 [thread overview]
Message-ID: <20170123190729.74057d6f@free-electrons.com> (raw)
In-Reply-To: <20170122210551.9704-1-peter@korsgaard.com>
Hello,
On Sun, 22 Jan 2017 22:05:51 +0100, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/833/8334631b54fdfd43d38ca00f42e4d5a98e3a70c4/
> http://autobuild.buildroot.net/results/9c0/9c08e0b745fab671123facb4a46f60eec5afd718/
>
> Commit 24d90db52a74 (package/nodejs: disable icu support for host build)
> added --with-intl=none to host configure flags to fix an issue related to
> icu. The 0.10.x version unfortunately doesn't understand this configure
> flag and errors out when provided, breaking the build:
>
> configure: error: no such option: --with-intl
>
> The 0.10.x version doesn't seem to have this icu issue (E.G. no autobuilder
> issues before this commit and unable to reproduce locally), so fix it by
> only passing --with-intl=none for the 6.9.x version.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/nodejs/nodejs.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-01-23 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 21:05 [Buildroot] [PATCH] nodejs: unbreak 0.10.x host build Peter Korsgaard
2017-01-23 8:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123190729.74057d6f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox