From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 24 Jan 2017 22:20:10 +1300 Subject: [Buildroot] [V2 1/3] pkg-perl: add PREFER_INSTALLER variable In-Reply-To: <20170124082534.21033-1-francois.perrad@gadz.org> References: <20170124082534.21033-1-francois.perrad@gadz.org> Message-ID: <20170124222010.2a6acb8f@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 24 Jan 2017 09:25:32 +0100, Francois Perrad wrote: > Signed-off-by: Francois Perrad > --- > docs/manual/adding-packages-perl.txt | 8 ++++++-- > package/pkg-perl.mk | 20 ++++++++++++++------ > 2 files changed, 20 insertions(+), 8 deletions(-) Thanks for this v2, but I've already reviewed and it doesn't seem like you have taken into account my comments. There has been no reply from you to the comments I made on the v1, and there is no changelog in your v2 to understand what has changed compared to v1. When there are review comments, it would be useful if you could *reply* rather than just sending a new version that fixes some of the comments and totally ignores the rest of the comments ? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com