From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] bctoolbox: new package
Date: Tue, 24 Jan 2017 22:36:32 +1300 [thread overview]
Message-ID: <20170124223632.2d264e8d@free-electrons.com> (raw)
In-Reply-To: <20170122210021.9463-1-joerg.krause@embedded.rocks>
Hello,
On Sun, 22 Jan 2017 22:00:20 +0100, J?rg Krause wrote:
> diff --git a/package/bctoolbox/Config.in b/package/bctoolbox/Config.in
> new file mode 100644
> index 000000000..ee0757856
> --- /dev/null
> +++ b/package/bctoolbox/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_BCTOOLBOX
> + bool "bctoolbox"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
BR2_INSTALL_LIBSTDCPP dependency was missing here: there is some C++
code in this library. So I've added that.
> +ifeq ($(BR2_STATIC_LIBS),y)
> +BCTOOLBOX_CONF_OPTS += \
> + -DENABLE_SHARED=OFF -DENABLE_STATIC=ON
Those two lines could have been on the same line, it's about 60-62
characters long, it definitely fits in the 80 characters limit. So I've
fixed the three occurrences of this.
Applied with those fixes, as well as a follow-up commit that adds you
to the DEVELOPERS file for this package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-24 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 21:00 [Buildroot] [PATCH v2 1/2] bctoolbox: new package Jörg Krause
2017-01-22 21:00 ` [Buildroot] [PATCH v2 2/2] package/ortp: bump version to 0.27.0 Jörg Krause
2017-01-24 9:39 ` Thomas Petazzoni
2017-01-24 9:36 ` Thomas Petazzoni [this message]
2017-02-07 11:20 ` [Buildroot] [PATCH v2 1/2] bctoolbox: new package Peter Korsgaard
2017-02-07 12:54 ` Jörg Krause
2017-02-07 13:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124223632.2d264e8d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox